fix(nodekit): align ActiveGraph native identity replay - #607
Draft
HomenShum wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size advisoryThis PR adds 764 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC. If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
This is advisory — it does not block the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rejectverdictRoot cause
The production exporter and JavaScript wrapper already supported
session.nativeIdentityand graph lifecycle events, but the Python evaluator and JSON Schema still enforced the older export shape. Unit coverage had therefore tested asymmetric boundaries. The first owner-authorized production export exposed the mismatch.Result
All 20 owner-authorized exports validated and retained persistence/reload parity after the fix. ActiveGraph was 14,003.6x slower than canonical validation at the median and added no material explanatory value, triggering both predefined stop conditions. It remains an optional offline diagnostic canary and is not production authority.
The committed receipt excludes owner identifiers, run identifiers, exported events, databases, and private evidence directories.
Validation
npx vitest run scripts/__tests__/collectActiveGraphCorpus.test.ts scripts/__tests__/nodekitActiveGraphCorpus.test.ts scripts/__tests__/nodekitActiveGraphCanary.test.ts— 23 passedpython -m pytest evals/activegraph/tests -q— 50 passedreject, 20 exports, andownerDataIncluded: falsegit diff --checkpassed