Skip to content

sorbet: Update RBI files. - #24354

Merged
MikeMcQuaid merged 1 commit into
mainfrom
sorbet-files-update
Oct 25, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
sorbet-files-update

Conversation

@BrewTestBot

Copy link
Copy Markdown
Contributor

Autogenerated by the sorbet workflow.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f8357eb-45b8-490f-b1b6-88bc68bc7463
Commits

Reviewing files that changed from the base of the PR and between c5b9f65 and 2cf4e1a.

Files selected for processing: 1
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/env_config.rbi

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Refactor
    • Updated the declared return types for curl and Git path lookups to indicate that either may return no value. This aligns the available type information with the possibility of a missing path; runtime behaviour is unchanged.

The generated RBI signatures for Homebrew::EnvConfig.curl_path and Homebrew::EnvConfig.git_path now declare nullable string return types.

Changes: EnvConfig signatures

Layer / File(s) Summary
Path method return types
Library/Homebrew/sorbet/rbi/dsl/homebrew/env_config.rbi
The curl_path and git_path signatures now return T.nilable(::String).

Priority: Low

Merge Risk: Minimal · up to 2cf4e

No merge-blocking issue was identified in the generated RBI updates.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the Sorbet RBI file update, which matches the main change.
Description check Passed The description states that the change was autogenerated by the Sorbet workflow, which is directly related to the RBI file update.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MikeMcQuaid
MikeMcQuaid enabled auto-merge October 25, 2026 13:16
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 8d79935 Oct 25, 2026
61 of 62 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the sorbet-files-update branch October 25, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants