Repository navigation
download_queue: name the download in checksum mismatch errors - #24353
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Use downloadable messages in checksum reports Library/Homebrew/download_queue.rb, Library/Homebrew/test/download_queue_spec.rb |
Both fetch paths pass the downloadable message to the alignment helper. Tests check the Bottle testball label in stderr and, in serial mode, the downloaded-file checksum in stdout. |
Priority:
Merge Risk: 
Minimal · up to 27ec6
-
The checksum mismatch output change is ready to merge with no identified user-impacting risk.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the change: checksum mismatch errors in the download queue now name the download. This matches the raw summary, which says the labels now use the downloadable's message, and the PR objectives, which say the resource name is added to each error. The title is specific and concise.
Full details: Description check
-
Explanation
The description explains the problem and the intended result. When several resources fail SHA-256 verification, the error does not name the resource. It gives an example output and shows the corrected output with the resource name. This matches the changes to the download queue and its spec file.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?I used Claude Fable 5.1 to generate the fix and reviewed it manually.
If multiple resources have a SHA mismatch, the error was not naming the resource, only stating
Resource reports different checksum, one example I encountered:This PR ensures the resource is named: