Repository navigation
Publish local patch checksums in the formula API - #24284
Merged
Merged
Conversation
MikeMcQuaid
added this pull request to stack #24286
October 17, 2026 15:13
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
474d60f1-6dbf-43bc-8ed8-9ab271e81944
📒 Files selected for processing: 6
Library/Homebrew/api/formula_struct.rbLibrary/Homebrew/formula.rbLibrary/Homebrew/formulary.rbLibrary/Homebrew/test/api/formula/formula_struct_generator_spec.rbLibrary/Homebrew/test/formula_spec.rbLibrary/Homebrew/test/formulary_spec.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
MikeMcQuaid
force-pushed
the
publish-local-patch-checksums
branch
2 times, most recently
from
October 17, 2026 16:46
370d6ba to
d516bff
Compare
dduugg
approved these changes
Oct 18, 2026
- Generate digests for stable, HEAD and resource patch files without adding checksums to formula definitions. - Preserve the digests through the public and internal API formats. - Reject unreadable patches during API generation before incomplete metadata can be published.
MikeMcQuaid
force-pushed
the
publish-local-patch-checksums
branch
from
October 18, 2026 12:06
d516bff to
dbe090b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.
Summary by CodeRabbit