Skip to content

Synchronize shared configuration - #24221

Merged
p-linnane merged 2 commits into
mainfrom
sync-shared-config
Oct 11, 2026
Merged

p-linnane merged 2 commits into
mainfrom
sync-shared-config

Conversation

@BrewTestBot

Copy link
Copy Markdown
Contributor

This pull request was created automatically by the sync-shared-config workflow.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 703a1b91-58aa-40c7-bc75-d4e5e8b34690

📥 Commits

Reviewing files that changed from the base of the PR and between 6971647 and d0fd497.


📒 Files selected for processing (2)
  • .github/workflows/check-prs.yml
  • docs/Homebrew-Governance.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📜 Recent review details
⏰ Context from checks skipped due to timeout. (19)
  • GitHub Check: docker (x86_64 Ubuntu 24.04)
  • GitHub Check: docker (arm64 Ubuntu 24.04)
  • GitHub Check: docker (arm64 Ubuntu 26.04)
  • GitHub Check: docker (x86_64 Ubuntu 26.04)
  • GitHub Check: tests (load-only macOS)
  • GitHub Check: tests (macOS, 1/2)
  • GitHub Check: tests (Linux, 1/2)
  • GitHub Check: tests (Linux, 2/2)
  • GitHub Check: tests (online, 1/2)
  • GitHub Check: tests (generic OS, 2/2)
  • GitHub Check: tests (no Sorbet)
  • GitHub Check: tests (online, 2/2)
  • GitHub Check: tests (load-only Linux)
  • GitHub Check: tests (macOS, 2/2)
  • GitHub Check: tests (generic OS, 1/2)
  • GitHub Check: workflow_syntax
  • GitHub Check: syntax
  • GitHub Check: Analyze
  • GitHub Check: docs

🧰 Additional context used
📚 Code guidelines (1)
docs/AGENTS.md — auto-discovered

📓 Path-based instructions (1)
Source excerpt: Use the system Homebrew `brew bundle exec ...`

📄 CodeRabbit inference engine (docs/AGENTS.md)

Files:

  • docs/Homebrew-Governance.md

🔇 Additional comments (1)
docs/Homebrew-Governance.md (1)

24-25: LGTM!



📝 Summary

Summary by CodeRabbit

  • New Features
    • Pull request checks now distinguish missing descriptions from incomplete templates. Eligible open pull requests receive a reminder when a description is missing, and the reminder is removed once a description is added.
  • Documentation
    • Governance guidance now describes quarterly Maintainer reporting using the Maintainers listed at quarter-end and preceding full quarterly reports to assess multi-quarter role requirements. It retains the guidance to review recommendations against discretion, exceptions, and non-numerical eligibility criteria.

Walkthrough

The pull request workflow now checks for missing descriptions and manages related comments. The governance guidance changes Maintainer reporting coverage and the reports used for role recommendations.

Changes

Pull Request Description Checks

Layer / File(s) Summary
Description status outputs
.github/workflows/check-prs.yml
The workflow sets has_description for recognized bump-tool PRs. It runs the description checker alongside the full-template checker, validates both outputs, and publishes them.
Missing-description comment lifecycle
.github/workflows/check-prs.yml
The workflow finds marked comments and deletes them when a description is present. When the PR is eligible, the full template is complete, and the description is missing, it posts a marked request if no matching comment exists.

Quarterly Maintainer Reporting

Layer / File(s) Summary
Quarterly reporting rules
docs/Homebrew-Governance.md
The guidance bases reporting coverage on Maintainers listed at quarter-end. It uses preceding full quarterly reports for role recommendations and removes the monthly contribution-count, latest-quarter assessment, and incomplete-history omission rules.

Priority: ⚪ Not assessed

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: mikemcquaid


Merge Risk: ⚪ Minimal · up to d0fd4

This automated sync adds a separate check for a missing pull request description and a matching reminder comment. It also updates the quarterly Maintainer reporting guidance. The description checker that the workflow downloads already supports the new check, and no blocking issues remain.

Architecture Summary

Architecture risk: 🔵 Low · up to d0fd4

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/Homebrew-Governance.md: Reporting coverage changes from Maintainers listed at month-end to those listed at quarter-end. The role-recommendation column now uses preceding full quarterly reports rather than up to four full monthly or historical quarterly reports; the monthly contribution-count and latest-quarter assessment definitions, and the incomplete-history omission rule, are removed.
  • observed — Modified behavior in .github/workflows/check-prs.yml: Recognized bump-tool PR bodies now also set has_description=true.
  • observed — Modified behavior in .github/workflows/check-prs.yml: The workflow now runs the description checker alongside the full-template checker, validates both outputs as boolean values, and publishes both; invalid pairs fail with an error.
  • observed — Modified behavior in .github/workflows/check-prs.yml: The reopen step now has the reopen ID, allowing later steps to inspect its outcome.

Pre-merge checks | Passed 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title accurately identifies the main change: synchronizing shared configuration. It is concise and specific.
Description check Passed The description states that the pull request was created by the shared-configuration synchronization workflow. It is related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@p-linnane
p-linnane added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit b922623 Oct 11, 2026
53 checks passed
@p-linnane
p-linnane deleted the sync-shared-config branch October 11, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants