Repository navigation
Suppress developer mode warnings in CI - #24220
Merged
Merged
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk | ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: suppressing Homebrew developer mode warnings in CI. |
| Description check | |
The description directly explains how the workflows and Dockerfile set developer mode to suppress CI warnings, including the reason for different configurations. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI jobs that run developer commands without
HOMEBREW_DEVELOPERwarn that developer mode has been automatically turned on. The developer automation jobs insorbet.yml,spdx.yml,sponsors-maintainers-man-completions.yml,vendor-gems.ymlandvendor-version.ymlnow set it at job level, while the Docker workflow andDockerfileset it only on the commands that need it.copilot-setup-steps.ymlrunsbrew developer oninstead, because Copilot ignores job-levelenv. The Docker image itself still ships without developer mode.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?GPT-6 Astra drafted the changes and ran
brew lgtm, actionlint, offline zizmor, a scope check confirming the workflows are otherwise unchanged and a smoke test of the warning andbrew developer onwith real commands in a disposable clone. Claude Code (Opus 5.5) reviewed them, rerunning that smoke test, checking that every developer command in the affected workflows is covered and confirming against GitHub's documentation that Copilot ignores job-levelenv. I reviewed the diff.