Repository navigation
Split slow test jobs - #23675
Merged
Merged
Split slow test jobs#23675
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds test-file sharding to reduce CI duration while retaining legacy check names.
Changes:
- Adds and tests
brew tests --shard=<index>/<total>. - Splits four slow CI jobs into two shards.
- Updates generated documentation, completions, and Sorbet definitions.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/tests.yml |
Shards CI tests and adds result jobs. |
Library/Homebrew/dev-cmd/tests.rb |
Implements shard parsing and selection. |
Library/Homebrew/test/dev-cmd/tests_spec.rb |
Tests shard selection. |
Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/tests.rbi |
Adds the typed shard argument. |
docs/Manpage.md |
Documents --shard. |
manpages/brew.1 |
Updates the generated manpage. |
completions/bash/brew |
Adds Bash completion. |
completions/fish/brew.fish |
Adds fish completion. |
completions/zsh/_brew |
Adds zsh completion and conflicts. |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/dev_cmd/tests.rbi: File type not supported
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
force-pushed
the
split-slow-test-jobs
branch
from
August 28, 2026 07:43
202a86c to
eb06e07
Compare
MikeMcQuaid
force-pushed
the
split-slow-test-jobs
branch
2 times, most recently
from
August 28, 2026 12:38
c630a17 to
2b93e5e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MikeMcQuaid
force-pushed
the
split-slow-test-jobs
branch
from
August 28, 2026 13:46
2b93e5e to
efc29b5
Compare
- Balance four slow test groups by source size across two shards. - Preserve required checks with independent aggregate jobs. - Share test setup through a reusable workflow. - Start test jobs without waiting for syntax checks. - Fail CI tests when required dependencies are unavailable. - Replace prefix-cache actions with direct installs where still needed.
MikeMcQuaid
force-pushed
the
split-slow-test-jobs
branch
from
August 28, 2026 13:59
efc29b5 to
c261086
Compare
- Test every documented command through an outside-in smoke path. - Record child coverage with Ruby `Coverage` and skip Sorbet loading. - Build installed fixtures directly and combine Formula and Cask paths.
Speed up and expand integration coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 sol xhigh with local review and testing.