Skip to content

sync: keep newer action pins in synced workflows - #514

Merged
p-linnane merged 1 commit into
mainfrom
keep-newer-action-pins
Nov 19, 2026
Merged

p-linnane merged 1 commit into
mainfrom
keep-newer-action-pins

Conversation

@p-linnane

@p-linnane p-linnane commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

A synced repository can update an action before its source repository does, through a manual bump or its own Dependabot run, and the sync then copied the older pin back, as in Homebrew/formulae.brew.sh#2386. The sync now keeps a target's pin wherever it pins the same action repository at a newer version than the source, in both the template workflows and the docs.yml synced from Homebrew/brew, and still takes newer source pins. Pins whose version comment isn't a comparable version are synced from the source as before. The schedule comments now say that every repository's Dependabot updates run on Friday.

Claude Opus 5.5 wrote the change, ran brew style and the shared configuration spec with Portable Ruby 4.0.10, checked that three of the five new examples fail without the change and ran the old and new sync scripts against a Homebrew/formulae.brew.sh clone: the old script downgrades five pins and the new one keeps them, with otherwise identical changes.

@p-linnane
p-linnane requested a review from a team as a code owner November 19, 2026 18:44
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Improvements
    • Synced workflows and configuration now retain a valid action version already in the destination when it is newer than the source. Newer source versions are still applied; versions that cannot be compared do not replace the source pin.
    • Updated the scheduled sync description to clarify its timing in relation to Friday’s Dependabot updates across synced repositories. The schedule itself is unchanged.

The sync process compares valid action pins in source and target content. It retains a target pin when its version is newer. The process applies this transformation to documentation workflows and applicable configuration content. Scheduling comments now describe Friday updates between Wednesday sync jobs.

Changes: Action pin preservation

Layer / File(s) Summary
Compare and repin action versions
.github/actions/sync/shared-config.rb, .github/actions/sync/shared-config_spec.rb
The helper compares valid versions by case-insensitive repository name and substitutes a newer target pin’s SHA and version. The repin helper preserves an optional path.
Apply pin preservation during sync
.github/actions/sync/shared-config.rb, .github/actions/sync/shared-config_spec.rb, .github/workflows/sync-shared-config.yml
Documentation workflows and applicable configuration content pass through the helper. Specs cover newer target pins, older source pins, repeat syncs, and pins that are not reconciled. Scheduling comments describe Friday updates between Wednesday sync jobs.
Merge Risk: Minimal · up to 301c8

The sync now keeps newer action pins in the target repository, including quoted or differently spaced entries, instead of downgrading them. No remaining merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "sync: keep newer action pins in synced workflows" matches the main change. The PR makes the sync keep a target repository's newer action pin instead of copying an older source pin, for the …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that the sync now keeps a target's newer action pin instead of downgrading it, in both the template workflows and the synced docs.yml. It also covers the non-comparable version …
Full details: Title check

Explanation

The title "sync: keep newer action pins in synced workflows" matches the main change. The PR makes the sync keep a target repository's newer action pin instead of copying an older source pin, for the same action repository with comparable version comments. The title is short, specific, and states the primary behaviour change.

Full details: Description check

Explanation

The description states that the sync now keeps a target's newer action pin instead of downgrading it, in both the template workflows and the synced docs.yml. It also covers the non-comparable version comment case and the Friday Dependabot schedule comment change, all of which match the raw summary and objectives. It gives a concrete reproduction example and test results. The description is related to the changeset.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 8f8090d0-4bd1-4fb7-92d0-66fd13c9a261
Commits

Reviewing files that changed from the base of the PR and between 0d2477d and 301c890.

Files selected for processing: 2

  • .github/actions/sync/shared-config.rb
  • .github/actions/sync/shared-config_spec.rb

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 3a18bf66-1bc6-4177-b1da-a9582e90aa52
Commits

Reviewing files that changed from the base of the PR and between d439e35 and 0d2477d.

Files selected for processing: 3

  • .github/actions/sync/shared-config.rb
  • .github/actions/sync/shared-config_spec.rb
  • .github/workflows/sync-shared-config.yml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Comment thread .github/actions/sync/shared-config.rb Resolved
Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane
p-linnane force-pushed the keep-newer-action-pins branch from 0d2477d to 301c890 Compare November 19, 2026 21:50
@p-linnane
p-linnane enabled auto-merge November 19, 2026 22:05
@p-linnane
p-linnane merged commit d5d803f into main Nov 19, 2026
28 checks passed
@p-linnane
p-linnane deleted the keep-newer-action-pins branch November 19, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants