Skip to content

sync: exclude private from CodeRabbit sync - #511

Merged
MikeMcQuaid merged 1 commit into
mainfrom
sync-exclude-private-coderabbit
Nov 12, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
sync-exclude-private-coderabbit

Conversation

@p-linnane

Copy link
Copy Markdown
Contributor

Homebrew/private has its own .coderabbit.config.ts, which its CODEOWNERS assigns to the Security Team, and the sync replaces it with the shared configuration. Excluding it also stops the sync checking that its CODEOWNERS has the shared entries, but it already has them and a spec in its required checks verifies them on every pull request.

Claude Opus 5.5 wrote the change, ran brew style and the shared configuration spec with Portable Ruby 4.0.9 and checked that the new example fails without the exclusion.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane
p-linnane requested a review from a team as a code owner November 12, 2026 05:20
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • The private repository is now excluded from shared CodeRabbit configuration and CODEOWNERS syncing, alongside the existing excluded repositories. Other repositories’ sync behavior is unchanged.
  • Tests
    • Updated the exclusion checks to cover the private repository.

The shared-config sync exclusion list now includes private. The existing test checks that shared files are not installed and existing configuration is preserved for that repository name.

Changes: Shared config exclusion

Layer / File(s) Summary
Add and test the repository exclusion
.github/actions/sync/shared-config.rb, .github/actions/sync/shared-config_spec.rb
The sync exclusion list now includes private. The existing test checks that shared files are not installed and existing configuration is preserved for this repository name.
Merge Risk: Minimal · up to 9d0b9

The change stops the shared CodeRabbit configuration sync from overwriting the private repository's own configuration. Its test coverage is extended to match. No merge-blocking risk is identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the CodeRabbit sync now excludes the private repository. It matches the raw summary, which adds private to coderabbit_excluded_repositories, and the PR objectives,…
Description check Passed The description states the reason for the change. Homebrew/private has its own .coderabbit.config.ts, and the sync would replace it. It also explains the side effect on the CODEOWNERS check and list…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the CodeRabbit sync now excludes the private repository. It matches the raw summary, which adds private to coderabbit_excluded_repositories, and the PR objectives, which describe the same exclusion. The title is short and specific.

Full details: Description check

Explanation

The description states the reason for the change. Homebrew/private has its own .coderabbit.config.ts, and the sync would replace it. It also explains the side effect on the CODEOWNERS check and lists the verification steps. This matches the raw summary and the objectives.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 36942704-8f16-4c5e-b6a7-9965c3f74547
Commits

Reviewing files that changed from the base of the PR and between 799b7f8 and 9d0b9b3.

Files selected for processing: 2

  • .github/actions/sync/shared-config.rb
  • .github/actions/sync/shared-config_spec.rb

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid merged commit 2636e20 into main Nov 12, 2026
28 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the sync-exclude-private-coderabbit branch November 12, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants