Skip to content

Revert "check-prs: use curl to reduce GitHub REST API usage" - #510

Merged
cho-m merged 1 commit into
mainfrom
revert-check-prs
Nov 10, 2026
Merged

cho-m merged 1 commit into
mainfrom
revert-check-prs

Conversation

@cho-m

@cho-m cho-m commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

This reverts commit 60933af.

We fixed excessive GitHub REST API usage elsewhere so can restore this.

Also raw.githubusercontent.com is included in shared 5k/hour unauthenticated rate limit so hard to tell impact. And there may be a request-per-minute usage limit.


Personally not sure how above limits works out within GitHub-hosted runner. At least the authenticated REST API limit is clearly defined and trackable so may be better for us to keep using.

This reverts commit 60933af.

We fixed excessive GitHub REST API usage elsewhere so can restore this.

Also raw.githubusercontent.com is included in shared 5k/hour
unauthenticated rate limit so hard to tell impact.
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the automated pull-request validation workflow to retrieve its template and checker through GitHub’s content service instead of downloading raw files from the main branch.
    • Existing template validation behavior remains unchanged, so contributors should see the same checks and results when opening pull requests. No changes were made to the validation criteria.

The workflow now retrieves the pull request template and template checker through GitHub’s Contents API. It decodes each response’s base64 .content field to the existing local file. The template checks are unchanged.

Changes: Template retrieval

Layer / File(s) Summary
Fetch and decode template files
.github/workflows/check-prs.yml
The workflow uses gh api to retrieve the template from the current repository and the checker from Homebrew/.github. It decodes each response’s .content field to the existing local file.
Merge Risk: Minimal · up to faa0f

The workflow switches template downloads to authenticated API requests. No merge-blocking issue was established.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly states that the change reverts the earlier use of curl, which matches the workflow change to retrieve files through GitHub’s Contents API.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains the change: it reverts the workflow’s use of GitHub’s Contents API and discusses the rate-limit considerations behind that decision.
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 937fbd53-3f52-4b4c-9d1f-5aff53823a07
Commits

Reviewing files that changed from the base of the PR and between f021304 and faa0f02.

Files selected for processing: 1

  • .github/workflows/check-prs.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@cho-m
cho-m merged commit 799b7f8 into main Nov 10, 2026
31 checks passed
@cho-m
cho-m deleted the revert-check-prs branch November 10, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants