Repository navigation
Add migration - #126
Merged
Merged
Add migration#126
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mar-crespo
reviewed
Sep 10, 2026
| }, | ||
| ), | ||
| migrations.CreateModel( | ||
| name='Question', |
Collaborator
There was a problem hiding this comment.
let's make sure we're setting db_table for all so naming stays consistent. look at AnonymousName and StudyGroup too
mar-crespo
reviewed
Sep 10, 2026
| ('details', models.TextField()), | ||
| ('create_time', models.DateTimeField(auto_now_add=True)), | ||
| ('last_updated_time', models.DateTimeField(auto_now=True)), | ||
| ('hearts', models.IntegerField(default=0, validators=[django.core.validators.MinValueValidator(0)])), |
Collaborator
There was a problem hiding this comment.
nit: let's keep this consistent with PositiveIntegerField typing we gave above for heart in CustomerUser, Answer, and Comment
mar-crespo
requested changes
Sep 10, 2026
mar-crespo
left a comment
mar-crespo
left a comment
Collaborator
There was a problem hiding this comment.
Overall, looks good, just some comments to nitpick. Also, I think we should look over the schemas and the naming convention we use to make sure everything is consistent. Feel like it would make things easier to read and understand for new team members when they onboard.
mar-crespo
approved these changes
Sep 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes