fix(tui): the dock's GIT, FILES and NOTES views are real, on one git probe (#6565 C)

[Hmbown]

Summary

Third #6565 follow-up: the dock's GIT, FILES and NOTES views are real, and the git badge, the Git view and the model's per-turn git line all share one git probe. It is independent of #6634 and #6635.

One probe instead of three parsers

• git_status::probe_status replaces symbolic-ref, rev-list and status --porcelain with one git status --porcelain=v2 --branch -z. The new parse_porcelain_v2 reads head, upstream, ahead/behind, and staged, modified, untracked and conflicted counts with paths. Its classification is the one the composer badge always used.
• One rev-parse --git-dir --git-common-dir gives both the repository name and linked-worktree detection. log -5 --format=%h%x1f%s%x1f%cr gives recent commits.
• Git older than 2.11 (no porcelain v2) falls back to the old three calls.
• workspace_context no longer runs git of its own. The badge reads the shared snapshot through context_line, and an explicit refresh after a tool forces a probe. The engine's per-turn git line (workspace_context::collect, engine.rs) is now one status call through the same parser and formatter.
• Net: 6 git processes per chrome probe instead of 7-8. The badge's own 2-3 processes every 15s are gone, and the engine turn line uses 1 process instead of 2-3. The module doc's invocation list is updated.
• Probe gate: chrome keeps the existing gate. In addition, while the Git view is showing, the probe runs during turns and agent runs too (git_probe_allowed), on the same 2s TTL, off-thread, with GIT_OPTIONAL_LOCKS=0.

Views

• GIT:
  • the branch with ↑ahead ↓behind, "up to date", or "no upstream", plus the forge slug
  • a changes summary, with the changed paths (first 20) in the inspector
  • linked worktrees, including agent worktrees
  • the last 5 commits
  • empty states that say what is true: "reading git status…" before the first probe, "not a git repository" only when the probe found none, and "git unavailable: " when git failed
• FILES: the edited files, each with +A −D and its change evidence in the inspector, then the files read. It reads the settled_file_activity that project() already computes each frame, now stored on WorkSurfaceState, so there is no second history scan and no new cache.
• NOTES: one row per /note note, and Enter runs /note show n. The notes file is read off the render path with the workspace context on its existing tick, through the note command's own resolver (commands::notes_path / read_notes). A /note command refreshes it at once. The empty hint is "/note add to keep a note".

Design corrections, stated here as the design asked

• The design said the TUI badge should "derive from cached_status()". Read naively, an explicit refresh (after a shell or exec tool that changed the branch) would show a 2s-stale cache. So an explicit refresh forces the probe, and the TTL-driven refresh reads the cache.
• The invocation count is asserted by construction and by the real-repository probe test, which goes through the single status call. I did not add a fake-git-on-PATH counting test.

Scope

Refs #6565. Does not close it. Still open: PR D (agent progress on the mobile page, and sub-agent cache in session totals). #6634 (names and results) and #6635 (notices, shells, stalls) are in review.

Testing

• CARGO_BUILD_JOBS=3 scripts/dev-cargo.sh test -p codewhale-tui --lib -- git_status workspace_context work_surface git_probe note engine::tests tui::ui:: worktree history: 1786 passed, 0 failed, 4 ignored.
• cargo fmt --all -- --check: pass.
• clippy with the CI flags on codewhale-tui: clean.
• The three budget scripts and scripts/split/module_graph.py --check: pass.
• Changelog checks all pass: sync-changelog, the web derive scripts, check-versions, contributor-credit and public-copy vitest (6 passed).

New tests:

• The porcelain v2 fixture: ordinary, renamed (with its extra record), unmerged, untracked and ignored entries, a path with a space, detached and unborn heads.
• v1 output is rejected so the caller falls back, and the v1 parser handles that fallback.
• The log parse.
• A probe of a real temporary repository fills the branch, the changes, the commits and the badge string, and workspace_context::collect agrees with it.
• The Git view's state rows: before the probe, another workspace, not a repository, git unavailable.
• The Git view's full rows: upstream, no upstream, detached, worktrees, commits, and the inspector paths.
• FILES rows and the tab count, NOTES rows and the Enter action.
• The git probe is allowed mid-turn only while the Git view is showing.
• The existing badge TTL tests were updated to the shared probe.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.