feat(web_search): add Serply search provider - #6100
Merged
Merged
Conversation
Add Serply (https://serply.io) as an opt-in `[search]` provider alongside Sofya and the other keyed backends. `provider = "serply"` sends `GET https://api.serply.io/v1/search?q=...&num=...` with the key in an `X-Api-Key` header and maps `results[].title/link/description` onto `WebSearchEntry`; ads, knowledge graph and related questions are ignored. The key comes from `[search] api_key` or the `SERPLY_API_KEY` env var. Preflight fails closed with a clear message when neither is set, and `SERPLY_API_KEY` joins the workspace `.env` credential allowlist. `BackendId::Serply` records receipts, `api.serply.io` is the network-policy and `default_backend_host` host, and `search_probe_target` covers it for `doctor`. Firecrawl stays the default; existing configs are unchanged. Docs: config.example.toml, docs/CONFIGURATION.md and the zh_hans copy. Signed-off-by: googio <59339358+googio@users.noreply.github.com>
Contributor
|
Thanks @googio for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…nd chain run_serply_search classified a missing API key as ExecutionFailed, which run_backend_chain treats as recoverable, so a configured Serply route that reached the adapter after a failed provider-native attempt degraded to DuckDuckGo instead of stopping. Classify it as InvalidInput, matching the preflight not_configured path, and pin the classification with a test that fails without the change. Signed-off-by: googio <59339358+googio@users.noreply.github.com>
Hmbown
enabled auto-merge (squash)
September 12, 2026 05:32
Owner
|
The updated Serply branch was waiting for GitHub workflow approval: its current head had no completed build/test verdict. I have approved the CI, OpenHarmony, DCO, issue-link and web runs for 7741753. The missing-key review finding is resolved in the current code. Merge remains gated on the actual run results and final source review; the contributor does not need to rebase to get these checks started. |
Hmbown
added a commit
that referenced
this pull request
Sep 13, 2026
Saved agent profiles that are malformed, unreadable or duplicated now fail explicitly at Agent and Fleet dispatch, including when the name shadows a built-in role. The parent's default route is never substituted silently; other valid profiles stay usable and a valid project override still wins. `agent(action: "roster")` reports bounded profile identities and paths without parser excerpts. Document the valid personal profile format and that `[permissions]` cannot widen the parent's authority. On Linux, finishing a transcript or composer selection publishes PRIMARY through one bounded background arboard worker (X11 and Wayland data control), leaving the regular clipboard unchanged. Middle-click inside the composer pastes PRIMARY at the pointer without submitting. Native access is refused over SSH without a forwarded display; modal ownership, Unicode hit testing and non-Linux behavior are unchanged. Enable arboard's `wayland-data-control` feature; the lockfile adds only its 14 dependencies. Add release-note receipts for #6116, #6117 and the Serply provider (#6100) and regenerate the packaged changelog. Closes #6117. Closes #6116. Validation on the qualified source tree 361a6ab06d22 (this source with the pre-minimized lockfile): full workspace/all-features Cargo 15,431 passed, 0 failed, 29 ignored (four libtest threads); workspace/all-targets check, CI-equivalent Clippy and formatting passed; npm test 521 passed, 0 failed; check:web passed. The final lockfile was re-derived with `cargo update --workspace` (added packages only) and passes `cargo metadata --locked`; check-versions and feature release-note receipts pass. Native Linux clipboard modules passed cross-application X11, headless Wayland/Sway, SSH-refusal and headless checks in an isolated container. Hosted CI, the release executable and installation are separate evidence. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Hmbown
added a commit
that referenced
this pull request
Sep 13, 2026
Regenerate web/lib/changelog.generated.ts from CHANGELOG.md and add the #6100, #6116 and #6117 contributors to the website credit arrays and docs/CONTRIBUTORS.md so the parity gates hold. Hosted Web Frontend on 080cae8 failed exactly these two parity tests. Validation: web lib/changelog, lib/public-copy and lib/public-installer-contract tests: 18 passed, 0 failed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Serply (https://serply.io) as a
[search]provider for the Web tool, following the shape of the Sofya adapter in #2790.provider = "serply"callsGET https://api.serply.io/v1/search?q=...&num=...with the key in anX-Api-Keyheader and mapsresults[].title/link/descriptionontoWebSearchEntry. Ads, knowledge graph and related questions in the response are ignored.[search] api_keyor theSERPLY_API_KEYenv var; preflight fails closed with a clear message when neither is set, andSERPLY_API_KEYjoins the workspace.envcredential allowlist.BackendId::Serplyfor receipts,api.serply.iofor network policy anddefault_backend_host,search_probe_targetfordoctor.config.example.toml,docs/CONFIGURATION.md,docs/zh_hans/CONFIGURATION.md.Opt-in only: Firecrawl stays the default and nothing changes for existing configs. No new dependencies. CHANGELOG files untouched per CONTRIBUTING.
Disclosure: I work with Serply.
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked(warning-free under the CI allow list)cargo test --workspace --all-features --locked: every other crate green (40 suites, 2339 tests);codewhale-tui12224 unit tests plus the cucumber and integration targets green. Theruntime_api::testsmodule is order-sensitive in my WSL environment (a different handful of its tests fail on every run of the module, on untouchedmainas well); each of those tests passes when run alone on this branch.New tests:
serply_search_url_encodes_query_and_result_count,parse_serply_results_reads_link_and_description_and_skips_malformed_rows,serply_provider_without_api_key_surfaces_clear_error_not_silent_fallback, the Serply rows indoctor_search_probe_targets_cover_every_builtin_providerandevery_configured_provider_maps_to_one_explicit_backend_adapter, and two config parse/round-trip tests.Live check with a real key (
SERPLY_API_KEY,provider = "serply"): a query throughweb_searchreturned ranked Google results with titles, URLs and snippets andsource: "serply"in the receipt; with the key removed the tool fails closed with the Serply message instead of falling back.Checklist