Skip to content

fix(whaleflow): reject unknown workflow references#2837

Merged
Hmbown merged 1 commit into
codex/v0.9.0-stewardshipfrom
codex/v090-whaleflow-reference-validation
Jun 6, 2026
Merged

fix(whaleflow): reject unknown workflow references#2837
Hmbown merged 1 commit into
codex/v0.9.0-stewardshipfrom
codex/v090-whaleflow-reference-validation

Conversation

@Hmbown
Copy link
Copy Markdown
Owner

@Hmbown Hmbown commented Jun 6, 2026

Summary

  • reject unknown depends_on_results, reducer inputs, and teacher-review candidates in typed WhaleFlow IR before mock execution or replay
  • run the same reference validation at the Starlark compile gate so generated workflows fail closed earlier
  • keep dynamically expanded nodes on shape validation only, since Expand.source can describe an external/generated source label in the current mock executor

Stewardship

Refs #2670, #2673, #2726, and #2667. This is a narrow maintainer hardening slice inspired by the WhaleFlow direction in #2482/#2486 without merging the broad draft runtime/worktree surfaces. Thanks @AdityaVG13 for the WhaleFlow draft and cost-tracking direction.

Verification

  • cargo test -p codewhale-whaleflow --locked
  • cargo fmt --all
  • ./scripts/release/check-versions.sh
  • ./scripts/release/check-ohos-deps.sh
  • cargo clippy -p codewhale-whaleflow --all-targets --locked -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check
  • cargo check --workspace --all-features --locked

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@Hmbown Hmbown merged commit 6bb564e into codex/v0.9.0-stewardship Jun 6, 2026
2 checks passed
@Hmbown Hmbown deleted the codex/v090-whaleflow-reference-validation branch June 6, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant