feat(config): add provider TLS skip verify#2834
Merged
Hmbown merged 1 commit intoJun 6, 2026
Merged
Conversation
Harvests the provider-scoped TLS configurability direction from #1893 while keeping the setting disabled by default and limited to the active LLM provider client. SSL_CERT_FILE remains the preferred custom CA path, and doctor reports the setting when enabled. Co-authored-by: wavezhang <832911+wavezhang@users.noreply.github.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harvests a narrow, provider-scoped slice of #1893 from @wavezhang:
[providers.<name>] insecure_skip_tls_verify = true, disabled by defaultdanger_accept_invalid_certs(true)only to the LLM provider HTTP clientSSL_CERT_FILEas the preferred custom-CA path and documents this as a last resortcodewhale doctoroutputAlso includes a tiny
expect_errclippy cleanup incrates/tui/src/prompts.rsbecause it blockedcargo clippy -p codewhale-tui --all-targets --locked -- -D warningson this branch.Credit
Thanks @wavezhang for the original #1893 direction. This PR keeps the useful intent while avoiding a broad/global TLS bypass and keeping the stale/conflicting source PR open for traceability.
Verification
cargo test -p codewhale-config insecure_skip_tls_verify --lockedcargo test -p codewhale-tui insecure_skip_tls_verify --lockedcargo test -p codewhale-tui build_http_client --lockedcargo test -p codewhale-tui doctor_tls_status --lockedcargo test -p codewhale-config project_merge_denies_credentials_endpoints_and_provider_selection --lockedcargo check -p codewhale-tui --all-features --locked./scripts/release/check-versions.sh./scripts/release/check-ohos-deps.shgit diff --checkcargo clippy -p codewhale-tui --all-targets --locked -- -D warnings