feat(whaleflow): add serializable run result records#2815
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
Hmbown has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces serializable result records (BranchResult, LeafResult, and ControlNodeResult) along with supporting enums (WorkflowRunStatus, ControlNodeKind) and corresponding serialization tests to support the TraceStore contract. The review feedback suggests optimizing the serialized JSON payload size by omitting None values for optional fields (notes, output, and summary) using #[serde(skip_serializing_if = "Option::is_none")].
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| #[serde(default)] | ||
| pub notes: Option<String>, |
There was a problem hiding this comment.
To keep the serialized JSON representation clean and compact (especially for TraceStore storage), consider omitting None fields from serialization using #[serde(skip_serializing_if = "Option::is_none")].
#[serde(default, skip_serializing_if = "Option::is_none")]\n pub notes: Option<String>,| #[serde(default)] | ||
| pub output: Option<String>, |
There was a problem hiding this comment.
To keep the serialized JSON representation clean and compact (especially for TraceStore storage), consider omitting None fields from serialization using #[serde(skip_serializing_if = "Option::is_none")].
#[serde(default, skip_serializing_if = "Option::is_none")]\n pub output: Option<String>,| #[serde(default)] | ||
| pub summary: Option<String>, |
There was a problem hiding this comment.
To keep the serialized JSON representation clean and compact (especially for TraceStore storage), consider omitting None fields from serialization using #[serde(skip_serializing_if = "Option::is_none")].
#[serde(default, skip_serializing_if = "Option::is_none")]\n pub summary: Option<String>,1 participant
Summary
Stewardship notes
This is a narrow maintainer slice toward #2668. It preserves the WhaleFlow direction from #2482/#2486 and keeps @AdityaVG13 credited in the changelog, but deliberately avoids enabling a
workflow_runtool, executor behavior, or guessed TraceStore migrations before replay/cancellation/worktree semantics are proven.Verification
cargo test -p codewhale-whaleflow --locked./scripts/release/check-versions.shcmp -s CHANGELOG.md crates/tui/CHANGELOG.md && echo changelogs-matchgit diff --check