Skip to content

feat(web_search): enable parallel execution for read-only search tool #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Implementist wants to merge 1 commit into from
Closed

feat(web_search): enable parallel execution for read-only search tool #2509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/tui/src/tools/web_search.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ impl ToolSpec for WebSearchTool {
ApprovalRequirement::Auto
}

fn supports_parallel(&self) -> bool {
true
}
Comment on lines +189 to +191
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 No regression test pins supports_parallel() to true. A future refactor that accidentally removes or moves this override would silently re-serialize all web searches with no failing test to catch it. Adding assert!(WebSearchTool.supports_parallel()) in the existing #[cfg(test)] block would lock the contract.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex Fix in Claude Code Fix in Cursor


async fn execute(&self, input: Value, context: &ToolContext) -> Result<ToolResult, ToolError> {
let query = extract_search_query(&input)?;
if query.is_empty() {
Expand Down
Loading