fix: harden multi-tenant isolation after PR #291 merge review - #292
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix: harden multi-tenant isolation after PR #291 merge review#292cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Move rate limiting after auth so tier quotas use resolved tenant, not spoofable X-Tenant-ID headers. Scope analytics, chains, and reviews to effectiveTenantID; enforce tenant checks on skill/chain/review CRUD; use requestContextWithTenant for memory update/history/restore paths; add X-Tenant-ID to CORS allowlist; propagate TenantID on Review type. Co-authored-by: Himan <Himan-D@users.noreply.github.com>
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
agent-memorydash | a0d8b4b | Jul 17 2026, 05:53 PM |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
hystersis-app | a0d8b4b | Jul 17 2026, 05:58 PM |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
hystersis-docs | a0d8b4b | Jul 17 2026, 06:01 PM |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
agent-memory | a0d8b4b | Jul 17 2026, 06:04 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge stability review of PR #291 (multi-tenant SaaS isolation) found several tenant scoping gaps. This PR closes them without changing public API shapes.
Type
Changes
X-Tenant-IDheaderseffectiveTenantID(r)requestContextWithTenant(r)for memory update, history, version restore (fixes broken updates for non-default tenants)X-Tenant-IDto CORS allowlist (api.go + session.go)TenantIDontypes.Reviewfor review isolation checksTesting
go build ./... go test -short ./... go vet ./...Deploy impact
api.hystersis.com)Agent notes
Cloud Agent PR on
cursor/*— auto-merge when CI Success passes.