🛡️ Sentinel: [CRITICAL] Fix SQL injection in pgvector table name - #284
🛡️ Sentinel: [CRITICAL] Fix SQL injection in pgvector table name#284Himan-D wants to merge 1 commit into
Conversation
Co-authored-by: Himan-D <262577684+Himan-D@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
agent-memorydash | af63471 | Jul 15 2026, 05:38 AM |
|
Agent guard: Please use Conventional Commits PR titles, e.g. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
hystersis-app | af63471 | Jul 15 2026, 05:42 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
hystersis-docs | af63471 | Jul 15 2026, 05:45 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
agent-memory | af63471 | Jul 15 2026, 05:47 AM |
🚨 Severity: CRITICAL
💡 Vulnerability: The pgvector client was interpolating the configured table name directly into SQL queries using
fmt.Sprintf. While this comes from configuration, it presents a SQL injection risk if the configuration is dynamically populated or manipulated.🎯 Impact: An attacker could execute arbitrary SQL commands if they could control the
PGVECTOR_TABLEenvironment variable.🔧 Fix: Added strict regex validation (
^[a-zA-Z0-9_.]+$) during client initialization to ensure the table name only contains valid characters for SQL identifiers.✅ Verification: Handled via local test suites (
go test ./...) and compilation checks (go build ./...).PR created automatically by Jules for task 10310101027776565373 started by @Himan-D