Skip to content

Conversation

@vivi-o
Copy link
Contributor

@vivi-o vivi-o commented Jan 16, 2026

No description provided.

@vivi-o vivi-o requested a review from spellingcat January 16, 2026 00:39
@vivi-o
Copy link
Contributor Author

vivi-o commented Jan 16, 2026

so for the feed vs scoring thing I'm not exactly sure what you had in mind. Do we want feed and scoring to be triggered by same button and for the robot to choose based on if it can score and the operator can override? Or will they just be seperate things? So far i just have it so that scoring req requires it to be in the right place and for it to be our turn to score so we dont score at the wrong time. I guess we wouldn't want to feed if we are in the scoring place and its our turn so i can add that.

@vivi-o
Copy link
Contributor Author

vivi-o commented Jan 16, 2026

nvm i have to fix the game data thing and use a timer

@vivi-o
Copy link
Contributor Author

vivi-o commented Jan 16, 2026

will work on this tn

@spellingcat
Copy link
Member

yeah so i think eventually what we want to move towards is the driver pressing 1 button and then the robot decides what to do. i think that would mean scoreReq and feedReq get like combined into one shootReq. i haven't actually looked at your code yet but what i guess this would look like would be:

ready/intake -(shootReq && our turn && in alliance zone)-> score
ready/intake -(shootReq && in neutral zone)-> feed (doesn't really matter if it's our turn or not because we can't score from the neutral zone)

and yeah shootReq && not our turn && in alliance zone shouldn't do anything

@vivi-o vivi-o requested a review from spellingcat January 17, 2026 21:11
Copy link
Member

@spellingcat spellingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i talked to cassie and basically she a) wants to be able to feed from everywhere and b) feeding should be a diff button from scoring which yknow is not what i had envisioned personally but it's fine lol. anyway just 1 thing about the get alliance thing

Base automatically changed from feature/alpha-state-machine to main January 19, 2026 18:53
Copy link
Member

@spellingcat spellingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to merge main in as well. keep your definitions of feed + score req

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants