fix SDK build and Python packaging for ubuntu 20.04#7
Open
Rorschach2333 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR standardizes the SDK naming and build/install workflow across C++ and Python, aligning the exported CMake package name with hightorque_motor and updating docs and configs accordingly.
Changes:
- Switch Python binding and CMake integration to depend on
hightorque_motor(exported targethightorque_motor::hightorque_motor) instead ofhightorque_robot. - Update build/install instructions to modern CMake (
-S/-B,cmake --build,cmake --install) and pip-based Python installs. - Update robot YAML naming (
robot.name→robot.robot_name) and make C++ config parsing backward-compatible.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| panthera_python/setup.py | Passes Python3_EXECUTABLE to CMake to match find_package(Python3 ...). |
| panthera_python/scripts/motor_example/motor_README.md | Updates build commands and pip usage in example docs. |
| panthera_python/robot_param/Leader.yaml | Renames YAML key to robot_name. |
| panthera_python/robot_param/Follower.yaml | Renames YAML key to robot_name. |
| panthera_python/hightorque_robot/init.py | Adds package init to re-export pybind symbols. |
| panthera_python/README.md | Clarifies module/package relationships; updates build/install + verification steps. |
| panthera_python/CMakeLists.txt | Links Python extension against hightorque_motor::hightorque_motor; adjusts output dir logic. |
| panthera_cpp/robot_cpp/README.md | Clarifies build boundaries for robot_cpp vs installed motor SDK. |
| panthera_cpp/motor_cpp/src/hardware/robot.cpp | Improves YAML validation/backward compatibility; adds serial_id range check. |
| panthera_cpp/motor_cpp/doc/CLAUDE.md | Updates build/install instructions to modern CMake commands. |
| panthera_cpp/motor_cpp/cmake/hightorque_robotConfig.cmake.in | Updates package config contents to hightorque_motor naming and targets. |
| panthera_cpp/motor_cpp/README.md | Documents package/target names and updated build/install instructions. |
| panthera_cpp/motor_cpp/CMakeLists.txt | Raises CMake minimum version; switches config template filename to hightorque_motorConfig.cmake.in. |
| panthera_cpp/README.md | Adds naming mapping and clarifies when installing motor_cpp is required. |
Updates a usage guide to hightorque_motor naming and modern CMake workflow, but file path is missing in the diff metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.0.2) | |||
| cmake_minimum_required(VERSION 3.5) | |||
Comment on lines
+100
to
103
| ${CMAKE_CURRENT_SOURCE_DIR}/cmake/hightorque_motorConfig.cmake.in | ||
| ${CMAKE_CURRENT_BINARY_DIR}/hightorque_motorConfig.cmake | ||
| INSTALL_DESTINATION lib/cmake/hightorque_motor | ||
| ) |
| python -c "import hightorque_robot; print('✓ 电机 SDK 安装成功')" | ||
| python -c "import pinocchio as pin; print('✓ pin 安装成功')" | ||
| python -c "import yaml; print('✓ pyyaml 安装成功')" | ||
| python -c "from hightorque_robot import _hightorque_robot; print('电机 SDK 安装成功')" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
中文
本 PR 修复 Panthera-HT SDK 的构建与安装问题:
hightorque_motorCMake 包名和导出目标site-packagesrobot.name与robot.robot_name已验证:
motor_cpp完整编译成功English
This PR fixes build and installation issues in the Panthera-HT SDK:
hightorque_motorCMake package and exported target namessite-packagesrobot.nameandrobot.robot_nameValidated:
motor_cppbuild succeeds