fix: add STANDARD to SmartBatteryImbalanceStrategy enum#133
Conversation
The API started returning "STANDARD" as an imbalance trading strategy, which fell through to UNKNOWN since the enum had no matching member.
Gids voor reviewers (ingeklapt bij kleine PR's)Gids voor reviewersVoegt ondersteuning toe voor de nieuwe "STANDARD" smart battery imbalance trading strategy-waarde en zorgt ervoor dat deze case-insensitive wordt geparseerd door de enum en de domeinparsingtests uit te breiden. Wijzigingen op bestandsniveau
Beoordeling ten opzichte van gekoppelde issues
Tips en commando'sInteractie met Sourcery
Je ervaring aanpassenGa naar je dashboard om:
Hulp krijgen
Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideAdds support for the new "STANDARD" smart battery imbalance trading strategy value and ensures it is parsed case-insensitively by extending the enum and its domain parsing tests. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds ChangesSmart battery strategy parsing
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Hey - ik heb je wijzigingen bekeken en ze zien er geweldig uit!
Sourcery is gratis voor open source – als je onze reviews nuttig vindt, overweeg dan om ze te delen ✨
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.



Summary
SmartBatteryImbalanceStrategyenum didn't have a member for, so it fell through toUNKNOWN.STANDARD = "standard"to the enum and a case-insensitive parsing test case alongside the existing ones.Fixes HiDiHo01/home-assistant-frank_energie#246
Test plan
pytest tests/test_domain.pypassesSummary by Sourcery
Ondersteuning toevoegen voor de STANDARD smart battery imbalance-strategiewaarde die wordt geretourneerd door de Frank Energie API.
Bugfixes:
SmartBatteryImbalanceStrategyenum-member in plaats van terug te vallen opUNKNOWN.Tests:
Original summary in English
Summary by Sourcery
Add support for the STANDARD smart battery imbalance strategy value returned by the Frank Energie API.
Bug Fixes:
Tests:
Summary by CodeRabbit
New Features
standardsmart battery imbalance strategy option.Tests