Repository navigation
ci: upload Playwright traces from test-results on failure - #1141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Frontend e2e job fails, the artifact step uploads
packages/frontend/playwright-report/. With thelistreporter (playwright.config.ts) that folder is never written, so a failed run has nothing to download. The release PR for 0.37.0 is an example:card-trial.spec.ts:224failed on both attempts and no trace was kept.Traces (
trace: 'on-first-retry') and the error-context files are written totest-results/, and that is what this PR uploads now.Changes
.github/workflows/playwright.yml: uploadpackages/frontend/test-results/on failure asplaywright-test-results, withif-no-files-found: ignoreand 14-day retention.Type
Testing
if: always()on a throwaway branch through 8workflow_dispatchruns; the artifact was created. That branch is deleted.Related
card-trial.spec.ts:224("a new cloud admin is offered the card trial once") is flaky on GitHub runners:/welcomeinstead of/start-trial), and both attempts failed on the 0.37.0 release PR;.nextand the CI env;trace: retain-on-failureall passed.With this change, the next failure leaves a trace to read.