Repository navigation
ci: add GitHub Actions smoke-test workflow - #7
Draft
HelloBryte wants to merge 1 commit into
Draft
HelloBryte wants to merge 1 commit into
HelloBryte wants to merge 1 commit into
Conversation
Deps (numpy 1.26.4, pygame 2.6.1) are already at the latest safe pins and the README's setup/CLI docs match the code, so no changes were needed there this pass. Adds a small CI workflow that was missing: on push/PR to main it installs requirements, syntax-checks all modules, and runs a full headless CLI game (depth 2) on Python 3.9 and 3.11 to catch regressions automatically instead of relying on manual "ran it locally" notes in PR descriptions. Also adds the resulting status badge to the README. This intentionally does not duplicate the LICENSE file, numpy 2.x bump, or unit test suite already proposed in the open, unmerged PRs #3, #4, and #5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine maintenance pass on this resume/portfolio repo.
requirements.txt:numpy==1.26.4is already the latest 1.x release andpygame==2.6.1is already the latest release overall, so there's no safe (non-major) version bump available. Left both pins as-is..github/workflows/ci.yml: a small GitHub Actions workflow (Python 3.9 + 3.11) that installsrequirements.txt, syntax-checks all five modules withpy_compile, and runs a full headless CLI game (python main.py --cli --quiet --depth 2withSDL_VIDEODRIVER=dummy) on every push/PR tomain. The repo had no CI at all, so this was a genuine gap and a low-risk, additive improvement — several past PRs' "test plans" have relied on manually re-running this same smoke test locally, so automating it seemed worthwhile.Note for the repo owner
This intentionally does not duplicate the work already sitting in open, unmerged draft PRs against this repo:
game_logic/ai_solverLICENSEfile (duplicates of each other); chore: routine maintenance - bump numpy, add LICENSE #4 also proposes anumpy2.x major bumpThose four PRs overlap with each other in places (e.g. #4/#5 both add the same
LICENSEfile) and might be worth reconciling — merging one, closing the duplicate — next time a human looks at this repo. No branches were deleted this pass since all four have unmerged work.Test plan
python -m py_compileon all five.pymodules — cleanrequirements.txtpython main.py --cli --quiet --depth 1and--depth 2full games run to completion (headless,SDL_VIDEODRIVER=dummy).github/workflows/ci.ymlYAML syntaxGenerated by Claude Code