Skip to content

fix: validate mentor issue URLs#44

Merged
Hell1213 merged 1 commit into
Hell1213:mainfrom
kunal-9090:codex-validate-mentor-issue-url
May 26, 2026
Merged

fix: validate mentor issue URLs#44
Hell1213 merged 1 commit into
Hell1213:mainfrom
kunal-9090:codex-validate-mentor-issue-url

Conversation

@kunal-9090
Copy link
Copy Markdown

Summary

  • validate the oss-dev-new mentor issue URL before starting mentoring
  • require a GitHub issues URL with a positive issue number
  • show a clear Typer error for missing, invalid, or non-positive issue numbers
  • add Typer CLI coverage for valid and invalid mentor inputs

Tests

  • uv run pytest tests\cli\test_new_cli.py tests\oss\test_github.py
  • uv run ruff check src\oss_dev\cli\app.py tests\cli\test_new_cli.py

Notes

  • Full suite: uv run pytest currently reports 54 passed and 3 existing failures in tests\cli\test_oss_commands.py because the legacy Click CLI exits early with a missing Gemini API key before argument validation.

Fixes #28

Copy link
Copy Markdown
Owner

@Hell1213 Hell1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid fix. Regex is robust and tests pass. Merging.

@Hell1213 Hell1213 merged commit 32ad58d into Hell1213:main May 26, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add input validation for issue number in mentor command

2 participants