fix(terminology): the HTS client must fail fast, not hang behind a proxy - #469
Open
angela-helios wants to merge 1 commit into
Open
fix(terminology): the HTS client must fail fast, not hang behind a proxy#469angela-helios wants to merge 1 commit into
angela-helios wants to merge 1 commit into
Conversation
test_in_modifier_fails_open_on_hts_unavailable points :in at a closed local port and expects fail-open within the 10s request timeout. On pool runners whose no_proxy excludes private ranges via CIDR — which reqwest cannot parse — the request detoured through the egress proxy and hung for minutes (789s in PR #466's run) before surfacing as a 500. The terminology server is a configured internal endpoint: the client now bypasses proxies outright, adds a 2s connect timeout so an unreachable server fails in milliseconds, and drops the silent unwrap_or_default() fallback that could discard both timeouts when the builder errs.
This was referenced Jul 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #470
The
test_in_modifier_fails_open_on_hts_unavailablefailure on PR #466's CI run (789s, then 500 instead of fail-open) is unrelated to that PR — it is the runner-proxy signature from #449 biting a third surface. The test points:inat a closed local port and expects connection-refused within the client's 10s timeout; on pool runners whoseno_proxyuses CIDR ranges (which reqwest cannot parse), the request detours through the egress proxy and hangs for minutes.Three-part hardening of the terminology client:
.no_proxy()— the HTS is a configured internal endpoint; egress proxying it is never right, and it silently breaks the fail-open semantics..connect_timeout(2s)— an unreachable server should fail in milliseconds, not consume the whole request budget.unwrap_or_default()fallback is gone: it could discard both timeouts when the builder errs, which is exactly the no-timeout hang observed. A client build failure is a startup-visible misconfiguration.All 4
terminology_integrationtests green locally (the unavailable-HTS one now completes in milliseconds).