test(composite): pin conformance seeding through to the search secondary - #468
Open
angela-helios wants to merge 1 commit into
Open
test(composite): pin conformance seeding through to the search secondary#468angela-helios wants to merge 1 commit into
angela-helios wants to merge 1 commit into
Conversation
Differential coverage for #462: the same seed_tenant_conformance call the server makes at startup, over a composite whose search secondary is a second SQLite backend, asserting both SearchParameters and CompartmentDefinitions drain through the async sync worker. Passing, which exonerates the generic composite/sync plumbing and narrows #462 to the Elasticsearch leg itself.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #471
Contributes to #462 (does not close it).
Differential test for the missing-CompartmentDefinitions mystery: the exact
seed_tenant_conformancecall the server makes, over a composite whose search secondary is a second SQLite backend, asserting both conformance sets drain through the async sync worker to the secondary. It passes — which exonerates the generic composite/sync plumbing and pins it against regressions.Findings so far posted on #462; the remaining suspects are ES-leg-specific and need a live-ES session.