feat(ui): Import/Export nav entries; the sidebar rail expands on hover - #440
Open
angela-helios wants to merge 6 commits into
Open
feat(ui): Import/Export nav entries; the sidebar rail expands on hover#440angela-helios wants to merge 6 commits into
angela-helios wants to merge 6 commits into
Conversation
The Batch & Data section catches up with the designs: an Import entry joins, and Bulk Export becomes Export (placeholders like their siblings until those pages exist). The explicit collapse toggle is gone with its nav.js state machine and the persisted expanded/collapsed preference. The sidebar is now a fixed icon rail that expands as an overlay while hovered or keyboard-focused, so the content column never reflows. The narrow-viewport media block and the has-nav-panel grid variants collapse into the one base state. Closes #438
position: fixed removes the sidebar from the grid flow, so the pane was auto-filling the rail column. The pane and the optional nav panel now name their columns.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Linux headless registers the initial pointer at (0,0) — over the rail — so pages opened with the sidebar expanded, overlaying the left content edge; any click landing under the overlay kept it hovered and intercepted forever. The page fixture now parks the pointer in the empty topbar after every goto, and the nojs nav-link tests hover the rail and wait for the expansion to settle before clicking, since item positions shift between the two states.
GET serves the empty settings document as a real representation ({} with
ETag "0"), but check_if_match mapped version 0 to 'no representation',
so the validator the GET handed out could never satisfy a conditional
write: a fresh user's read-then-conditional-write 412'd forever. Concrete
tag lists now evaluate against the version number including 0; If-Match: *
keeps requiring an actually stored document. The storage layer already
treated an expected version 0 as insert-if-absent on all four backends.
Closes #442
The 250px threshold accepted a mid-transition width, so the link could still be moving when the click landed.
Contributor
Author
|
CI status: everything is green except the one e2e failure — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #438
Closes #442
Two sidebar updates from the current designs:
Batch & Data entries. An Import entry joins the section (new mirrored icon), and Bulk Export becomes Export — placeholders like their siblings until those pages exist. Three locales updated.
Hover-expanding rail. The explicit collapse toggle is gone, together with nav.js, its
data-navstate machine, and the persisted expanded/collapsed preference (the/_user/settingsnavkey is simply no longer read). The sidebar is now a fixed icon rail that expands as an overlay while hovered — or keyboard-focused, so it stays keyboard-accessible — and the content column never reflows. The narrow-viewport media block and thehas-nav-panelgrid variants collapsed into the one base state, since the rail is now the resting state everywhere. Labels stay in the accessibility tree while the rail is closed (same visually-hidden pattern as before).Screenshots
Resting rail:
Hovered — expands as an overlay, with the new Import/Export entries:
Resources page (the three-column
has-nav-panellayout keeps its own columns):Tests
router_http: the page ships no toggle and no nav.js, and lists Import/Export.chrome.spec.tsrewritten: rail width at rest, expands on hover and on keyboard focus, collapses on leave, content column doesn't move, no toggle in the DOM, and the Batch & Data section lists Import/Export/SQL-on-FHIR. Full suite green locally (57 passed), a11y and no-cdn included.Update: the e2e
Recentfailure turned out to be a pre-existing server bug this PR uncovered (#442):GET /_user/settingshands outETag: "0"for the never-written document, butcheck_if_matchrejected that same validator on conditional writes, so a fresh user's read-then-conditional-write 412'd forever — previously masked by nav.js's unconditional first PATCH. The fix (one function inhandlers/user_settings.rs+ two regression tests, 25/25 inuser_settings) is folded into this PR;If-Match: *keeps requiring an existing document, and all four storage backends already treated expected version 0 as insert-if-absent.