ci(subscriptions): point channels workflow testcontainers at remote Docker host - #392
Merged
Conversation
…ocker host The self-hosted Linux runners no longer expose /var/run/docker.sock, so every testcontainer-based test in the channels workflow's unit-tests matrix panicked with SocketNotFoundError, and the email integration tests silently skipped via their docker_available() guard (#389). Add the DOCKER_HOST/DOCKER_HOST_IP env block that subscriptions-smoke.yml already uses, and run the unit-test step with --no-fail-fast so one failing test binary no longer hides the rest. Tests: validated by dispatching the workflow from feat/cluster-capable-state with this exact change (run 30099280985): all 112 jobs green, and the Email jobs' mailpit tests genuinely ran (5 passed in 1.94s vs the prior 0.01s silent skip).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
smunini
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #389. The
subscriptions-channels.ymlworkflow fails on the current[self-hosted, Linux]runner pool: the runners no longer expose a local/var/run/docker.sock, so every testcontainer-based test in the unit-tests matrix panics withSocketNotFoundError— and the email integration tests silently skip via theirdocker_available()guard, reporting green without testing anything.subscriptions-smoke.ymlalready adapted by pointing testcontainers at a remote Docker host viaDOCKER_HOST; the channels workflow never got that env block.Changes
.github/workflows/subscriptions-channels.yml:DOCKER_HOST: ${{ secrets.DOCKER_HOST }}/DOCKER_HOST_IPenv block used bysubscriptions-smoke.yml, with a comment referencing subscriptions-channels.yml fails on self-hosted Linux runners: no docker.sock (needs DOCKER_HOST env like smoke workflow) #389;--no-fail-fast, so a failing test binary no longer abortscargo testbefore the remaining suites (previously the persistence failure masked that the subscriptions test binaries never ran at all).Testing
feat/cluster-capable-state(run 30099280985): all 112 jobs green.5 passedin 1.94s, versus the prior 0.01s silent skip — becausedocker_available()also honorsDOCKER_HOST, so this change simultaneously un-breaks the unit tests and reactivates real email delivery coverage.Notes
feat/cluster-capable-state(feat(cluster): make HFS cluster-capable behind a load balancer #269) so this lands independently; feat(cluster): make HFS cluster-capable behind a load balancer #269 will pick it up on its next merge from main.