adds feature to detect multiple certificates in PEM bundles#182
adds feature to detect multiple certificates in PEM bundles#182mayrstefan wants to merge 1 commit intoHeinleinSupport:cmk2.3from
Conversation
If a PEM bundle contains multiple certificates only the first one is detected. This features adds further certificates to the JSON output: - first cert is shown as filename (#0 is omitted to stay compatible to previous outputs) - second cert is shown as filename#1 - third cert is shown as filename#2 - and so on This should solve HeinleinSupport#181
|
I am currently thinking about re-implementing the whole plugin in Python as all the string handling in Bash is getting out of hand. |
|
A disadvantage of a python solution on the agent would be the dependency to an addition module to read the certificates. AFAIK python does not include a (public) module to process x509 certificates. I'm no fan of telling people to just use When thinking about this PR I wanted to change or break as little as possible. Another refacoring step could be a refacoring that:
|
|
What is your current plan for this plugin? Is a python version still on the list or will it stay in bash (which I would prefer)? |
|
I am sorry but due to all the other extensions being migrated to 2.4 there was no room to think about this. |
If a PEM bundle contains multiple certificates only the first one is detected.
This features adds further certificates to the JSON output:
This should solve #181