Open
Conversation
my first contact with your code - i added the maven dependencies and stumpled into the wrong (your) StringUtils class and ended in an infinite loop. You should point out the very experimental state of your project!
|
The function No need to be insulting ("very experimental state"). May I point out that errors occur even in the most mature projects, in particular in unused code. For example, the widely known and respected Stanford CoreNLP package used to have an invalid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my first contact with your code - i added the maven dependencies and stumpled into the wrong (your) StringUtils class and ended in an infinite loop. You should point out the very experimental state of your project!