Eng: Kmp provided help center feature. Experimental#2917
Draft
StylianosGakis wants to merge 50 commits intodevelopfrom
Draft
Eng: Kmp provided help center feature. Experimental#2917StylianosGakis wants to merge 50 commits intodevelopfrom
StylianosGakis wants to merge 50 commits intodevelopfrom
Conversation
Until a KMP Markdown library exists, or we defer to a native SwiftUI implementation instead
# Conflicts: # app/data/data-changetier/build.gradle.kts # app/feature/feature-help-center/src/commonMain/kotlin/com/hedvig/android/feature/help/center/HelpCenterGraph.kt # app/feature/feature-home/src/main/kotlin/com/hedvig/android/feature/home/home/navigation/HomeGraph.kt # app/shareddi/src/nativeMain/kotlin/com/hedvig/android/shareddi/main.native.kt
On Android we use `AndroidUiDispatcher.Main`. On native we must use Dispatchers.Main to get the presenter running on the main threat which the DisplayLinkClock requires cashapp/molecule#547
This aims to help with the compose resources generation for all platforms https://kotlinlang.org/docs/multiplatform/whats-new-compose-180.html#support-for-multiplatform-resources-in-the-androidlibrary-target
This reverts commit 1645664.
This reverts commit dfbfdf0.
This should ensure that any Swift @MainActor-isolated implementation of the block will always be called on the correct thread, regardless of what dispatcher the surrounding Kotlin coroutine is using.
# Conflicts: # app/feature/feature-help-center/build.gradle.kts # app/feature/feature-help-center/src/commonMain/kotlin/com/hedvig/android/feature/help/center/data/GetMemberActionsUseCase.kt # app/feature/feature-help-center/src/commonMain/kotlin/com/hedvig/android/feature/help/center/data/GetQuickLinksUseCase.kt # app/feature/feature-terminate-insurance/build.gradle.kts # app/ui/ui-emergency/src/commonMain/kotlin/com/hedvig/android/ui/emergency/EmergencyScreen.kt # gradle/libs.versions.toml
StylianosGakis
force-pushed
the
feat/help-center-kmp
branch
from
bb6eedd to
3a79194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code to prepare for HedvigInsurance/ugglan#2363