Repository navigation
M3 G5 prep: W-49 twins, and probe twins chosen by class - #71
Merged
Merged
Conversation
…class lints W-49 gets a bad and a clean twin for each of its nine rules. The probe now proves a law judged m3 like a ticked one, names .astro files in its scratch tsconfig so the typed Astro rules find the twins, and leaves out the .astro twins of a class whose preset cannot lint them: an astro-site always lints them, a web-app only when the project depends on astro. Each skipped twin is named with its reason in the text and the JSON, and a probe with nothing left to judge exits 2 rather than passing. A real-tool test takes an astro-site project through W-22 and W-49 and turns one rule off to see its twin go red. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…empty probe is a report Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ns were skipped Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of two PRs for M3's step that proves the Astro rules live. It adds the W-49 twins and makes the law probe pick its twins by the file kinds each class can lint. The 62 accessibility twins follow in the step PR, once law rule entries can be limited to a class.
What it does
fixtures/laws/W-49/holds a bad and a clean.astrotwin for each of W-49's 9 rules. The W-22.tsxtwin is already onmain..astrotwin proves a law forastro-site, and forweb-apponly when the project depends onastro.--jsonoutput.**/*.astro, so typed Astro rules find their twins.judged: m3laws are probed as well asv0.1ones, so W-49 is proven.astro-siteproject through W-22 and W-49. It then turns one rule off and expects only that rule's twin to go red.Declared exceptions
The probe's own files belong to another lane. Its author reviews these edits:
src/laws/probe/{types,twins,judge,run,format,source}.tsand their tests;src/cli/laws-probe.ts;src/cli/laws-probe-{fake,ui}.test.ts;src/laws/probe/fixtures.test.ts, whose ES-module check skips.astro.src/cli/laws-probe-astro.test.tsis new. This PR edits noWEB_TOPS.md.Gate on this head
layers: 5 in range, 5 ran, 0 failed, 0 not-evaluated.🤖 Generated with Claude Code