Repository navigation
Stop a fixed test backend id colliding with a generated one - #19
Merged
Merged
Conversation
The backend-selection test added a Grafana backend with the fixed id grafana2, and the test helper renames grafana to grafana<N> from a counter shared by the whole package. Once N reached 2 the two ids collided, the loader saw a duplicate and the test got config_invalid instead of ambiguous_backend. Which run hit it depended on test order, so it passed on one OS and failed on the other. The extra backend is now grafana-extra, an id the counter cannot produce. The helper also checks the test config for a repeated id and fails with the cause named, so a future fixed id of that shape says what is wrong. Checked by repeating the selection test 40 times, by sixteen shuffle seeds under the race detector, and by putting the old id back: the helper then names the collision. Signed-off-by: VirtualMachinist <252028890+VirtualMachinist@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an order-dependent test failure on
main.TestGrafanaHealthBackendSelectioninserted a backend with a fixed id that the shared test helper could also generate from its counter. Under some shuffle orders the ids collided, and the command correctly reported an invalid config instead of the ambiguity the test expects.Test file only; no product code changes.
🤖 Generated with Claude Code