Repository navigation
Credit property and acceptance only on a matching passed test - #56
Merged
Merged
Conversation
…edit oracle evidence.rs reads a credited run's nextest JUnit report and passes a layer only on a passed test whose name holds the layer's test_filter. It is held under credit.rs until the gate wiring lands. tests/property.rs has nine proptest properties on the expiry date and glob rules. gate_credit.rs is the stub-driven oracle for the wiring and is red until then. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A credited layer passes on a passed test with a ::-separated name segment that starts with test_filter, so a test that only mentions the filter mid-name is no evidence. The kit guard checks no other kit test starts a name with property. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A credited property or acceptance layer passes only when the credited run's nextest JUnit report holds a passed test with a :: segment starting with the layer's test_filter (default property or acceptance). A layer that runs itself selects tests with the same rule through -E and --no-tests=fail. acceptance gets property's command and credit rule; it was NotRun. gates.property.test_filter and gates.acceptance.test_filter join the schema, section 6.5.1 and section 9.5. mod evidence moves into main.rs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Split the tag at its closing bracket instead of counting past it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A layer with no mapped command and a layer whose run kept a note both explain themselves in the report. One function now says which, which takes two branches out of unit_row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The JUnit report is read from the workspace root cargo metadata names plus nextest's store dir, never from CARGO_TARGET_DIR, and a report older than the credited run is not evidence. A failed evidence check is carried as the run note into stdout, detail and problems, and no longer blames a passing coverage run. test_filter is held to letters, digits and underscore in both schemas, so check refuses anything else and no escaping is needed. Real nextest tests cover a moved target dir, a moved store and a stale report. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…the stale rule The real-nextest fixture passed every cargo subcommand but metadata to a real cargo that has no deny on a runner, so security-advisory failed the gate; only metadata is real now. Every evidence failure names the layer and its filter. The stale rule compares the report's mtime with the credited run's own start and refuses a future date. The failed-coverage and unit/integration tests come back, and the real-nextest tests get a longer slow timeout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 1.3: a credited
propertyoracceptancelayer needs a matching passed test in the run it was credited from.propertyoracceptancetakes the coverage run, it passes only if that run's nextest JUnit report holds a passed test whose name has a::-separated segment starting with the layer'stest_filter. No match, only failed or skipped matches, or no JUnit report isfail. The detail names the filter and the path read, or[profile.ci.junit]. Nothing is built or run a second time.--no-tests=fail -E 'test(/(^|::)<escaped filter>/)'replaces the bare positional filter. That is a deliberate behaviour change: a test that only mentions the word, such asa_property_filter_that_matches_nothing_fails, is no longer evidence.gates.property.test_filter(defaultproperty) andgates.acceptance.test_filter(defaultacceptance), in the schema and its copy and inPROTOCOL.md§6.5.1 and §9.5.acceptancewasnot-runand exited 1. It now takesproperty's command and credit rule, with its own filter.tests/property.rsholds nineproptestproperties written from the spec: exemption date validity, the calendar, glob matching, and exemption liveness.proptest = "1"is a dev-dependency.laws_gate.rsfollows the new filter form. The unmapped-layer test usesmiriin place ofacceptance. No expectation was relaxed.Gate at the head: nextest 499 passed, 1 skipped;
73 mutants tested in 3m: 67 caught, 6 unviable;ok: 8 command(s) passed.🤖 Generated with Claude Code