Skip to content

Run nix flake check in CI so the existing flake critic actually runs - #2

Merged
NebuHedron merged 1 commit into
mainfrom
cursor/ci-flake-check-f732
Sep 1, 2026
Merged

NebuHedron merged 1 commit into
mainfrom
cursor/ci-flake-check-f732

Conversation

@NebuHedron

@NebuHedron NebuHedron commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

flake.nix already exposes checks.${system}.python-gate-runs (the product must produce output). CI never invoked that critic.

This is a thin workflow patch only:

  • After nix build, run nix flake check --print-build-logs
  • Rename the nix job from nix build + run to nix build + check + run

No flake, lockfile, product-closure, or template-rename changes.

Verified

  • flake.nix already defines checks.${system}.python-gate-runs
  • GitHub Actions run 33469280296 is green
  • Job nix build + check + run executed nix flake check --print-build-logs and built python-gate-runs.drv
  • Log: ✅ checks.x86_64-linux.python-gate-runs
Open in Web Open in Cursor 

The flake already exposes checks.${system}.python-gate-runs, but CI never
invoked nix flake check. Add that step next to nix build and rename the
job so the critic is part of the advertised gate.

Co-authored-by: NebuHedron <NebuHedron@users.noreply.github.com>
@NebuHedron
NebuHedron marked this pull request as ready for review September 1, 2026 04:19
@NebuHedron
NebuHedron merged commit 97660ad into main Sep 1, 2026
2 checks passed
VirtualMachinist added a commit that referenced this pull request Sep 13, 2026
Run nix flake check in CI so the existing flake critic actually runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants