Repository navigation
app: bump the Lapis pin to v0.5.0 to clear RUSTSEC-2026-0459 - #9
Merged
Merged
Conversation
The old pin brought in libsqlite3-sys 0.38.2, whose bundled SQLite is covered by RUSTSEC-2026-0459. Lapis 42aa3b8 (v0.5.0) is on rusqlite 0.42 and libsqlite3-sys 0.40. - lapis-lattice and lapis-notes: rev da4d1ce -> 42aa3b8 - rusqlite dev-dependency: 0.40 -> 0.42, to match the engine - rust-version: 1.85 -> 1.89, the engine's MSRV app/Cargo.lock was regenerated against the existing lock, so only the crates the bump needs moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VirtualMachinist
marked this pull request as ready for review
November 14, 2026 05:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears RUSTSEC-2026-0459 in the app.
cargo deny check (app)fails onmaind3b5128because the Lapis pinda4d1cebrings inlibsqlite3-sys0.38.2, whose bundled SQLite is covered by the advisory.Change
app/Cargo.toml:lapis-latticeandlapis-notes:revda4d1ce→42aa3b8dcdac51c684bd3cd4c3c6a5c3c17a9092(Lapis v0.5.0 release merge). The comment above them is updated.rusqlitedev-dependency:0.40→0.42. It has to match the engine's version, because the tests read the index file through it.rust-version:1.85→1.89, the engine's MSRV.app/Cargo.lockwas regenerated against the existing lock rather than from scratch, so only the crates the bump needs moved:da4d1ce42aa3b8Removed, because nothing depends on them any more:
bumpalo,cfg-if,hashbrown0.16.1,js-sys,rustversion,wasm-bindgen,wasm-bindgen-macro,wasm-bindgen-macro-supportandwasm-bindgen-shared.store.rsneeded no change. The workspaceCargo.lock, the bridge crates,ci.ymland the README are untouched.Runs
At this head, on a macOS arm64 build host, rustc 1.99.1, cargo-deny 0.18.9:
cargo deny --manifest-path app/Cargo.toml check: advisories, bans, licenses and sources all ok, exit 0.cargo check --manifest-path app/Cargo.toml --all-targets --locked: ok.cargo test --manifest-path app/Cargo.toml --locked: 12 passed and 1 ignored (the on-device Secure Enclave test), plus 3 doctests passed. That includes all the notes store tests.cargo clippy --manifest-path app/Cargo.toml --all-targets --locked -- -D warningsandcargo fmt --check: clean.Note: root
cargo deny checkand RUSTSEC-2026-0486CI is green on all three jobs at this head, including the repo-root
cargo-denyjob (cargo-deny 0.20.2). Run locally with cargo-deny 0.18.9, the root check reports RUSTSEC-2026-0486 (unsound, added 2026-11-11) againstrustix1.1.5 in the workspaceCargo.lock. That comes throughtempfile, a dev-dependency of the bridge crates, not from the app. #8 already movesrustixto 1.1.6 in the workspace lock. This PR leaves that lock alone, as scoped.🤖 Generated with Claude Code