Skip to content

app: bump the Lapis pin to v0.5.0 to clear RUSTSEC-2026-0459 - #9

Merged
VirtualMachinist merged 1 commit into
mainfrom
fix/pendant-lapis-pin
Nov 14, 2026
Merged

VirtualMachinist merged 1 commit into
mainfrom
fix/pendant-lapis-pin

Conversation

@VirtualMachinist

@VirtualMachinist VirtualMachinist commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Clears RUSTSEC-2026-0459 in the app. cargo deny check (app) fails on main d3b5128 because the Lapis pin da4d1ce brings in libsqlite3-sys 0.38.2, whose bundled SQLite is covered by the advisory.

Change

app/Cargo.toml:

  • lapis-lattice and lapis-notes: rev da4d1ce → 42aa3b8dcdac51c684bd3cd4c3c6a5c3c17a9092 (Lapis v0.5.0 release merge). The comment above them is updated.
  • rusqlite dev-dependency: 0.40 → 0.42. It has to match the engine's version, because the tests read the index file through it.
  • rust-version: 1.85 → 1.89, the engine's MSRV.

app/Cargo.lock was regenerated against the existing lock rather than from scratch, so only the crates the bump needs moved:

Crate Before After
lapis-lattice, lapis-notes 0.4.2 @ da4d1ce 0.5.0 @ 42aa3b8
libsqlite3-sys 0.38.2 0.40.0
rusqlite 0.40.2 0.42.0
rsqlite-vfs 0.1.1 0.2.0
sqlite-wasm-rs 0.5.5 0.6.3

Removed, because nothing depends on them any more: bumpalo, cfg-if, hashbrown 0.16.1, js-sys, rustversion, wasm-bindgen, wasm-bindgen-macro, wasm-bindgen-macro-support and wasm-bindgen-shared.

store.rs needed no change. The workspace Cargo.lock, the bridge crates, ci.yml and the README are untouched.

Runs

At this head, on a macOS arm64 build host, rustc 1.99.1, cargo-deny 0.18.9:

  • cargo deny --manifest-path app/Cargo.toml check: advisories, bans, licenses and sources all ok, exit 0.
  • cargo check --manifest-path app/Cargo.toml --all-targets --locked: ok.
  • cargo test --manifest-path app/Cargo.toml --locked: 12 passed and 1 ignored (the on-device Secure Enclave test), plus 3 doctests passed. That includes all the notes store tests.
  • cargo clippy --manifest-path app/Cargo.toml --all-targets --locked -- -D warnings and cargo fmt --check: clean.

Note: root cargo deny check and RUSTSEC-2026-0486

CI is green on all three jobs at this head, including the repo-root cargo-deny job (cargo-deny 0.20.2). Run locally with cargo-deny 0.18.9, the root check reports RUSTSEC-2026-0486 (unsound, added 2026-11-11) against rustix 1.1.5 in the workspace Cargo.lock. That comes through tempfile, a dev-dependency of the bridge crates, not from the app. #8 already moves rustix to 1.1.6 in the workspace lock. This PR leaves that lock alone, as scoped.

🤖 Generated with Claude Code

The old pin brought in libsqlite3-sys 0.38.2, whose bundled SQLite is
covered by RUSTSEC-2026-0459. Lapis 42aa3b8 (v0.5.0) is on rusqlite
0.42 and libsqlite3-sys 0.40.

- lapis-lattice and lapis-notes: rev da4d1ce -> 42aa3b8
- rusqlite dev-dependency: 0.40 -> 0.42, to match the engine
- rust-version: 1.85 -> 1.89, the engine's MSRV

app/Cargo.lock was regenerated against the existing lock, so only the
crates the bump needs moved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@VirtualMachinist
VirtualMachinist marked this pull request as ready for review November 14, 2026 05:05
@VirtualMachinist
VirtualMachinist merged commit e092c2f into main Nov 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant