Repository navigation
Close the open nits and add device pairing - #7
Merged
Merged
Conversation
Store::open no longer takes an index directory. Config is the vault and the inbox; the store picks the index in app-private storage itself, so a caller cannot hand it a symlink. The engine's own confinement still runs. The Android no_backup check now passes only the no_backup directory directly in the app's data directory. A decoy component elsewhere fails, and the comment says it is hygiene, not getNoBackupFilesDir(). Captured.index_error carries the kind of failure, never the engine's message, which can name vault paths. The backup-exclusion unsafe call has a SAFETY comment. app/src/platform/keystore.rs makes the device key: P-256 in the Secure Enclave via the Keychain, biometric per signature, this device only. The bridge format is a SEC1 public key and a DER ECDSA-SHA256 signature. Android returns Unsupported until an app shell owns Keystore and BiometricPrompt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PENDANT_BIND now accepts only loopback, Serve origin and scratch-path checks are pinned, and prompt, keys, approve, and worktree create require a phone-supplied signature plus an open grant. The app workspace is included in cargo deny. Co-authored-by: Cursor <cursoragent@cursor.com>
The QR nonce and revoke stay on the host, pairing signatures bind the device id and public key, revoked ids stay tombstoned, and the bridge verifies the phone P-256 signature with a one-time challenge. Co-authored-by: Cursor <cursoragent@cursor.com>
A loopback Host with a forwarding header is not local, so it cannot obtain a QR nonce or use host revoke. Writes dial the canonical scratch socket, and challenges expire and are rate limited. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
VirtualMachinist
marked this pull request as ready for review
October 31, 2026 14:30
VirtualMachinist
added a commit
that referenced
this pull request
Nov 14, 2026
Pairing cleanup after #7: Serve-mode warning, replay test, subtle, per-client challenge limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat/pendant-pairing.HostplusForwardedorX-Forwarded-Foris refused. The signed pairing message binds the device id and the public key.GET /v1/challengeis rate-limited and expires.cargo deny --manifest-path app/Cargo.toml check. Workflow actions are pinned to commit SHAs and checkout does not persist credentials.Test plan
check,banned-names, andcargo-denyare green on this head, including appcargo deny.Hostplus a forwarding header does not receive a pairing nonce.