Repository navigation
Pin the Lapis engine and add the notes store - #6
Merged
Merged
Conversation
Pin lapis-lattice and lapis-notes to git rev da4d1ce8 of Hedronite/lapis-lattice (GOAL-mobile G0-G3), not a crates.io version. app/ is its own workspace; until app/src/lib.rs lands, the store is the library root. app/src/notes/store.rs runs one worker thread that owns the Engine: - Engine::open_in with the index in app-private storage, embedder None. The engine refuses the vault, a path inside it, `..` and a symlink in before any write. On Apple the index directory is marked NSURLIsExcludedFromBackupKey; on Android it must sit under no_backup. - Engine::refresh on launch and foreground, off the calling thread; the result goes to a callback on the worker. - Capture through lapis_notes::create_new with created (YYYY-MM-DD) and inbox set and classify None; no process spawn, never overwrites. Tests drive the shipped Store: refusals with nothing written, index outside the vault and out of backups, refresh thread, a no-change refresh that commits nothing and keeps the index bytes, a refresh forced to fail mid-transaction that rolls back, and a second same-title capture that leaves the first file's bytes unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
app/ is its own workspace, so `cargo check --workspace` and `cargo test --workspace` at the root never compiled the notes store. Run both against app/Cargo.toml, --locked, in the same ubuntu job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VirtualMachinist
marked this pull request as ready for review
October 30, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lapis-latticeandlapis-notesto git revda4d1ce815d55f89db5cbf8ec2879e14f8957add.lapis-notesis unpublished, so this isrev =that sha, not a crates.io version.app/src/notes/store.rsopens the index outside the vault, refreshes off the calling thread, and captures throughcreate_newwithcreatedandinboxset. The embedder isNone..., or is a symlink is refused before a write. A second capture of the same title leaves the first file's bytes unchanged.Test plan
check,banned-names, andcargo-denyare green on this headcheckjob