Repository navigation
Tighten release-workflow guard, core trust-root build guard, default-feature run tests - #112
Merged
Merged
Conversation
Tests that spawn a child with a secret need --test-unconfined-hosts, which exists only with test-trusted-root, because a secret run with no allowed hosts is refused before spawn. Without the feature they failed. Gate them and their helpers on the feature so a default-feature run is green. The no-host refusal tests still run in both modes.
The guard accepted the trust-root check named anywhere, including in a comment, and missed flow-list and scalar on: triggers. It now strips comments, requires the check on a run: line or inside a run block, and detects release triggers in map, flow-list, and scalar form. Probe cases cover each trigger form, a reusable workflow that publishes, a comment-only mention, and a mention outside any run step.
geode-core refused the test-only trust-root feature only when debug assertions were off. Add a build.rs that also refuses it at any opt-level other than 0, matching the CLI guard, and correct the comments that said the debug-assertion check was the only one.
VirtualMachinist
marked this pull request as ready for review
October 26, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #111. Tightens the release-workflow guard, adds the optimized-build refusal to the core crate, and makes a default-feature
cargo test -p geode-clipass. No change togeoderuntime behavior..github/scripts/check-release-workflows.sh): comments are stripped before matching. The trust-root check must appear on arun:line or inside arun: |/run: >block, so a mention in a comment or anenv:value no longer counts. Release triggers are detected in map form, flow-list form (on: [push, release]), and scalar form (on: release). Reusableworkflow_callworkflows that publish are caught by their publish command.check-no-test-trusted-root.shruns ten probe cases: seven that must fail (tag push, flow list, scalar, map, a publishing reusable workflow, a comment-only mention, a mention outside any run step) and three that must pass.crates/geode-core/build.rsrefusestest-trusted-rootat any opt-level other than 0, matching the CLI guard. It checksOPT_LEVEL, because older Cargo does not pass the debug-assertion cfg to build scripts. The comments ininject.rsandCargo.tomlno longer say the debug-assertion check is the only one.tests/run_cli.rstests that spawn a child with a secret need--test-unconfined-hosts, which only exists withtest-trusted-root. Without the feature they hit the no-host refusal and failed. Those tests and their four helpers are now compiled only with the feature. The no-host refusal tests still run in both modes, and CI already runs this file with the feature. No product code changes.broken_rulesdoc comment intests/p0_custody_home.rsis back above its function.Test plan
cargo fmt --checkcargo clippy --workspace --all-targets -- -D warnings(default features)cargo clippy --workspace --all-targets --features test-trusted-root -- -D warningscargo test --workspace --locked --exclude geode-clicargo test -p geode-cli --locked --features test-trusted-rootcargo test -p geode-cli --locked(default features; failed 17 tests before this change).github/scripts/check-no-test-trusted-root.shand.github/scripts/check-release-workflows.sh--features test-trusted-root