Repository navigation
docs: pin signer workflow and tag on the runbook's attestation verify - #63
Merged
Merged
Conversation
Step 1 of the root-custody upgrade runbook ran `gh attestation verify` with `--repo` only, which accepts an attestation from any workflow in the repo, built from any ref. Pin `--signer-workflow` to release.yml, `--source-ref` to the version tag and `--source-digest` to the tag's commit, verify SHA256SUMS the same way, and check the archive with `shasum -c`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The install guide's provenance check ran `gh attestation verify` with `--repo` only. Use the same pins as the custody runbook (`--signer-workflow` release.yml, `--source-ref` the v0.8.0 tag, `--source-digest` its commit), verify SHA256SUMS too, and check the archive with `shasum -c` (`sha256sum -c` on Linux). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VirtualMachinist
marked this pull request as ready for review
October 31, 2026 15:06
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #62. Docs only:
docs/custody-upgrade-runbook.mdanddocs/install.md.Both files ran
gh attestation verify <archive> --repo Hedronite/facet.--repoalone accepts an attestation from any workflow in the repo, built from any ref. Both now:--signer-workflow Hedronite/facet/.github/workflows/release.yml,--source-ref refs/tags/v<version>and--source-digest <tag commit>(the tag commit comes fromgh api);SHA256SUMSwith the same pins, not only the archive;shasum -a 256 -c SHA256SUMS --ignore-missing(install.mdalso gives the Linuxsha256sum -cform).The runbook's step 1 now points to a new "Verify the release" block. The install guide's "Release archive provenance" block is replaced in place and keeps the literal
0.8.0used by the rest of that page.Checked against v0.8.0
I ran both blocks as written on the published assets:
facet-cli-0.8.0-macos-arm64.tar.gz,facet-cli-0.8.0-linux-x64.tar.gzandSHA256SUMS;shasum -cprintsOKfor both archives;--source-ref refs/tags/v0.7.9exits 1, so the pin rejects a wrong ref.No code, test, workflow or dependency changes.
🤖 Generated with Claude Code