draft changes to cs-api for DB based provider#133
Draft
grahamegrieve wants to merge 2 commits intomainfrom
Draft
draft changes to cs-api for DB based provider#133grahamegrieve wants to merge 2 commits intomainfrom
grahamegrieve wants to merge 2 commits intomainfrom
Conversation
jmandel
added a commit
to jmandel/FHIRsmith
that referenced
this pull request
Feb 21, 2026
…ffset/filterExclude Add Grahame's proposed decomposed filter API from PR HealthIntersections#133 alongside existing expandForValueSet. The new API pushes excludes and offset/count through the filter pipeline: cs-api.js: - handlesExcludes() / handlesOffset() capability queries - getPrepContext(iterate, offset, count) with paging params - filterExclude(ctx, filters[]) for exclude accumulation cs-sqlite-runtime-v0.js: - Implements all new API methods - filterExclude validates filters, throws for unsupported - executeFilters builds combined SQL with excludes + offset/count when accumulated, falls back to normal filter sets otherwise - Reuses #buildV0FilterSql / #buildV0ExcludeNotExists for SQL generation expand.js (worker): - scanValueSet() detects simple single-CS value sets - excludeFilterList() converts exclude clauses to {prop, op, value} - includeCodes passes excludes via filterExclude when CS handles them - Graceful fallback: if filterExclude throws, clears accumulated excludes and worker-side excludeCodes handles it All 22 cross-system tests pass with same results and performance. 52 pre-existing jest test failures unrelated to these changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.