Skip to content

[cmake] Recognize OpenBSD here - #329

Open
brad0 wants to merge 1 commit into
HaxeFoundation:masterfrom
brad0:cmake_openbsd
Open

brad0 wants to merge 1 commit into
HaxeFoundation:masterfrom
brad0:cmake_openbsd

Conversation

@brad0

@brad0 brad0 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tobil4sk

Copy link
Copy Markdown
Member

Is there a practical reason why this is needed? I think the only reason the os name is needed is for ci to be able to manage packages for various platforms. If there is no other reason, I think it's better to just remove the warning and keep the OS_NAME empty, otherwise this list will have to keep growing for every possible OS.

@brad0

brad0 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Is there a practical reason why this is needed? I think the only reason the os name is needed is for ci to be able to manage packages for various platforms. If there is no other reason, I think it's better to just remove the warning and keep the OS_NAME empty, otherwise this list will have to keep growing for every possible OS.

I haven't tracked this down and where it might go..

I just see below that..

set(bin_archive_name_we "neko-${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}-${OS_NAME}${arch_suffix}")
set(bin_archive_name "${bin_archive_name_we}.${bin_archive_format}")
set(CPACK_PACKAGE_FILE_NAME ${bin_archive_name_we})

I have no idea what package_choco is and I see the variables also referenced in Windows specific CMake bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants