[cppia] Fix missing jit exception checks for method calls

[tobil4sk]

Even with #1188, some checks for jit exceptions in interp code were still missing. This causes control flow bugs when local functions interact with other code, as they are currently not jit compiled.

In short, we have to make sure an exception hasn't been thrown after evaluating the object for a method call.

[Simn]

@hughsando Please check!

[tobil4sk]

@hughsando Please check!

It would be worth double checking if the full BCR_CHECKs are required in all cases, perhaps in some places it's enough just to check only ctx->exception.

CallFunExpr has the full check after getting this, and CallDynamicFunction has it after each argument, so I based my changes off those two. Perhaps there was a genuine reason why Call, CallHaxe and CallMemberVTable might not require the BCR check everywhere.

[tobil4sk]

It would be worth double checking if the full BCR_CHECKs are required in all cases, perhaps in some places it's enough just to check only ctx->exception.

I have added tests that verify that the full BCR check is needed for Call, CallHaxe, and CallMemberVTable. I had to use @:analyzer(ignore) to construct some pretty crazy expressions with return in different places where the old code would continue evaluating the args or even call the function despite a return.

So I think this is good to merge.

This didn't fix the issue in HaxeFoundation/haxe#12646, so that must be something else.

[Simn]

Hmm, this run seems to have had a weird state:

Run haxe compile-cpp.hxml -D HXCPP_M64 -D no_http
Error:  src/unit/TestCoroutines.hx:152: characters 29-52

 152 |  public function iterator():haxe.coro.AsyncIterator<Int> {
     |                             ^^^^^^^^^^^^^^^^^^^^^^^
     | Type not found : haxe.coro.AsyncIterator

This must mean that tests and std are not in-sync. Unrelated to this PR but something to look into because that can lead to all sorts of strange errors.

[tobil4sk]

Yeah, it looks like it just clones the latest haxe repository even if the haxe from build.haxe.org is slightly older. I guess we should read the commit hash from the version and use that, which is what the azure script used to do:

hxcpp/tools/azure-pipelines/build.yml

Line 145 in 8e3bc36

HAXE_HASH=`[[ "$HAXE_VERSION" =~ ^.+\+(.+) ]] && echo ${BASH_REMATCH[1]}`