Repository navigation
[stdhl] FileSystem: Fixed race in createDirectory - #13079
Open
TothBenoit wants to merge 1 commit into
Open
TothBenoit wants to merge 1 commit into
TothBenoit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createDirectorycreates each missing part of the path in turn, checkingexists(part)and then callingsys_create_dir. If another process creates that same directory between the check and the create,sys_create_dirfails and the function throws. The directory does exist at that point, and the levels below it are never created.This happens when several processes create overlapping directory trees at the same time, for example parallel asset converters writing under a shared output folder.
The fix: when
sys_create_dirfails, checkexists(part)again and throw only if the directory still isn't there, the same asmkdir -p.