Fix findFrame leak

[SimonArs]

Fixes FlxPoint leak in findFrame()

[MTUnixic]

will this be merged?

[SimonArs]

will this be merged?

idk

[Geokureli]

This fix is not as straight forward, and needs some changes. Also, this isn't really a high priority, tbh. I don't think this is going to impact anyones performance significantly, and if it does you could always just pass in a zero point and put() it yourself after

[SimonArs]

This fix is not as straight forward, and needs some changes. Also, this isn't really a high priority, tbh. I don't think this is going to impact anyones performance significantly, and if it does you could always just pass in a zero point and put() it yourself after

Actually it'll because functions like

flixel/flixel/graphics/frames/FlxAtlasFrames.hx

Line 243 in 5e147e8

var frames:FlxAtlasFrames = FlxAtlasFrames.findFrame(graphic);

and similar ones check for existence of frames but if point.equals itself calls putWeak then points that fail check simply remain in pool increasing it and you can’t manually call putWeak here

[Geokureli]

I think the existing setup of this method is bad practice, unconventional and I wanna take a closer look, when I have time. Please have a little patience.

We need to stop treating every PR like it's an urgent super-critical issue when we all know this will not greatly impact everyone's flixel game

If your project sorely need this change, let me know, and I'll bump it up in priority, but I really doubt that, as there's a pretty solid workaround and this method isn't called very often

[SimonArs]

I think the existing setup of this method is bad practice, unconventional and I wanna take a closer look, when I have time. Please have a little patience.

We need to stop treating every PR like it's an urgent super-critical issue when we all know this will not greatly impact everyone's flixel game

If your project sorely need this change, let me know, and I'll bump it up in priority, but I really doubt that, as there's a pretty solid workaround and this method isn't called very often

Okay, I guess I really need to slow down a bit
I'll close PR with comment

[Geokureli]

This is still a valid issue, and keeping it open serves as a reminder to me, to get to this when I do have time.

I mainly just don't want people coming in here and bumping these as if there's some kind of urgency, i.e.:

will this be merged?