use newline as DNA delimiter, update error check about layer names#1508
Open
RyanLucchese wants to merge 1 commit intoHashLips:mainfrom
Open
use newline as DNA delimiter, update error check about layer names#1508RyanLucchese wants to merge 1 commit intoHashLips:mainfrom
RyanLucchese wants to merge 1 commit intoHashLips:mainfrom
Conversation
…ntaining the DNA delimeter
zquestz
added a commit
to cashninjas/shinobi-art-engine
that referenced
this pull request
Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the default
DNA_DELIMITERto newline, as newlines are unlikely to occur in filenames and it makes the DNA more readableUpdated a check about the layer names containing the DNA delimiter to check the const value rather than hardcoded to -
Fixes #655