You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running the build command to generate 10,000 images can take a pretty long while to finish. This is true especially if you are running this program o a low budget computer with very little memory.
I noticed that the saveImage function is utilizing a writeFileSync in node is an asynchronous function that blocks the entire thread until the file is done writing to disc. To resolve this just converted this to a promise and moved some code around.
Another but very minimal change was adjusting for the deprecation of fs.rmdirSync(buildDir, { recursive: true }); by instead using fs.rmSync(buildDir, { recursive: true });.
With Sim-Labs-LLC:build_speed, for some reason, image weren't showing up in the image folder until the code finished.
My RAM usage also went up to an insane 99% level (terminal used 10 GBs of RAM alone), compared to 3 GB on hashlips:main)
So overall, this PR not only made my build time slower, it has a memory leak too. I can image a situation when Sim-Labs-LLC:build_speed is faster, but I couldn't get why would it be better for low-RAM computers.
I think instead of blindly converting asynchronous writeFileSync to Promise, which can cause RAM eating, we should rewrite the code to allow writing file parallelly in multiple threads.
TLDR:
Original: write file one by one
OP solution: write all file at once
Suggesting: write X files a times, X can be configured depends on the machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the build command to generate 10,000 images can take a pretty long while to finish. This is true especially if you are running this program o a low budget computer with very little memory.
I noticed that the saveImage function is utilizing a writeFileSync in node is an asynchronous function that blocks the entire thread until the file is done writing to disc. To resolve this just converted this to a promise and moved some code around.
Another but very minimal change was adjusting for the deprecation of fs.rmdirSync(buildDir, { recursive: true }); by instead using fs.rmSync(buildDir, { recursive: true });.