deploy: track the host-side Transmission hook wrapper - #1
Merged
Merged
Conversation
This script runs on the host (not in the container) and has lived only on swarm-manager at /opt/cascade-hook-wrapper.sh. A host rebuild would have lost it with nothing in git to say it existed. Committed verbatim from the deployed copy. Install instructions are in deploy/README.md -- note it must be chmod 755 on install, since git blobs created through the API land as 644.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Transmission completion hook has only ever existed on swarm-manager's
disk. A host rebuild would have lost it, with nothing in git to say it had
been there.
Found while auditing
/opt/faucet: the checkout had an untrackedfaucet-hook-wrapper.sh(mode 644, not executable, not gitignored). It turnedout to be a stale duplicate — byte-identical to the live
/opt/cascade-hook-wrapper.sh(755, root-owned), which is whatsettings.jsonactually points at. The hook works; it just wasn't versioned,and there were two near-identical copies on disk with nothing indicating which
one ran.
Changes
deploy/cascade-hook-wrapper.sh— the deployed script, verbatim, renamed tomatch its installed name. Header comment corrected: it previously said to
install at
/opt/faucet-hook-wrapper.sh, which is not where it lives.deploy/README.md— install steps, and the two failure modes worth knowing:the execute bit (files committed via the GitHub API land as 644, so
cpalone breaks the hook silently) and stopping the daemon before editing
settings.json, since transmission rewrites it on exit.Follow-up, not in this PR: delete the stale
/opt/faucet/faucet-hook-wrapper.shon swarm-manager so there's one source oftruth.