Repository navigation
feat(settings): polish Arrange apps reordering - #48
Open
manuel-rtsch wants to merge 5 commits into
Open
manuel-rtsch wants to merge 5 commits into
manuel-rtsch wants to merge 5 commits into
Conversation
Short keycap hint, Reset in Options, discard confirmation for pending edits, and keep the selected app in context with two rows above/below. Consume key repeats and restore focus so holding Up/Down no longer desyncs the highlight.
Use requestScrollToItem so the reorder and scroll land in the same measure pass, relax context to one row above/below, restore In dock labels, and split the key hint into two explicit rows.
The hint is now a focus target, so Up from the first app brings it back into view instead of stopping at the top row. Down returns to the first app.
manuel-rtsch
added a commit
to manuel-rtsch/Sidekit
that referenced
this pull request
Nov 10, 2026
Bring the Arrange apps polish from PR HarlenPostill#48 into integration: short two-row keypad hint, focusable hint, Reset in options, discard confirmation, one-row reorder context with requestScrollToItem, restored In dock labels, and focus/key-repeat fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Polishes Settings → Arrange apps so reordering is easier to follow with the keypad and safer to leave.
requestScrollToItemso the reorder and scroll land in the same measure pass, removing the one-frame flicker where the selected row appeared over its neighbour.The branch is based directly on
mainand contains only the Arrange apps changes.How to test
Real-device testing
4e3da19./gradlew :app:installDev, opened Settings → Arrange apps, and verified the hint, Reset placement, discard confirmation, reorder context, flicker fix, In dock labels, and focus restoration.Checklist
mainand this PR targetsmain.Build and automated test results
./gradlew :app:assembleDev— BUILD SUCCESSFUL./gradlew :app:installDev— BUILD SUCCESSFUL (installed on SP01_FE_GE)./gradlew spotlessCheck— BUILD SUCCESSFUL./gradlew :app:testDebugUnitTest --tests "hrln.interactive.sidekit.apps.settings.ArrangeHomeTest" --tests "hrln.interactive.sidekit.home.HomeArrangerTest"— BUILD SUCCESSFULKnown issues and exceptions
Maintainer review
Changes to
mainrequire approval from @HarlenPostill. Request review only when the required testing is complete.